You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/03/03 02:06:26 UTC

[GitHub] [incubator-mxnet] Zha0q1 commented on a change in pull request #19973: [v1.x] ONNX Fixes for some NLP models

Zha0q1 commented on a change in pull request #19973:
URL: https://github.com/apache/incubator-mxnet/pull/19973#discussion_r586051613



##########
File path: python/mxnet/contrib/onnx/mx2onnx/_op_translations.py
##########
@@ -822,7 +822,7 @@ def convert_leakyrelu(node, **kwargs):
             inputs=input_nodes,
             outputs=[name],
             name=name)
-    elif act_type in ('gelu'):
+    elif act_type in ('gelu',):

Review comment:
       otherwise this is not a tuple, and `elu` is in `gelu` so we will never go into the else branch




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org