You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tuscany.apache.org by ri...@apache.org on 2006/08/22 13:01:36 UTC

svn commit: r433593 - /incubator/tuscany/java/sca/databinding/databinding-sdo/src/main/java/org/apache/tuscany/databinding/sdo/ImportSDOLoader.java

Author: rineholt
Date: Tue Aug 22 04:01:36 2006
New Revision: 433593

URL: http://svn.apache.org/viewvc?rev=433593&view=rev
Log:
need to give better error info than NPE for bad wsdl location

Modified:
    incubator/tuscany/java/sca/databinding/databinding-sdo/src/main/java/org/apache/tuscany/databinding/sdo/ImportSDOLoader.java

Modified: incubator/tuscany/java/sca/databinding/databinding-sdo/src/main/java/org/apache/tuscany/databinding/sdo/ImportSDOLoader.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/databinding/databinding-sdo/src/main/java/org/apache/tuscany/databinding/sdo/ImportSDOLoader.java?rev=433593&r1=433592&r2=433593&view=diff
==============================================================================
--- incubator/tuscany/java/sca/databinding/databinding-sdo/src/main/java/org/apache/tuscany/databinding/sdo/ImportSDOLoader.java (original)
+++ incubator/tuscany/java/sca/databinding/databinding-sdo/src/main/java/org/apache/tuscany/databinding/sdo/ImportSDOLoader.java Tue Aug 22 04:01:36 2006
@@ -109,6 +109,9 @@
                     wsdlURL = uri.toURL();
                 }
                 wsdlURL = deploymentContext.getClassLoader().getResource(location);
+                if(null == wsdlURL){
+                    throw new LoaderException("WSDL location error '" +location+"'");
+                }
                 InputStream xsdInputStream = wsdlURL.openStream();
                 try {
                     XSDHelper xsdHelper = SDOUtil.createXSDHelper(typeHelper);



---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-commits-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-commits-help@ws.apache.org


Re: svn commit: r433593

Posted by Jim Marino <jm...@myromatours.com>.
On Aug 22, 2006, at 4:01 AM, rineholt@apache.org wrote:

> ====================================================================== 
> ========
> --- incubator/tuscany/java/sca/databinding/databinding-sdo/src/main/ 
> java/org/apache/tuscany/databinding/sdo/ImportSDOLoader.java  
> (original)
> +++ incubator/tuscany/java/sca/databinding/databinding-sdo/src/main/ 
> java/org/apache/tuscany/databinding/sdo/ImportSDOLoader.java Tue  
> Aug 22 04:01:36 2006
> @@ -109,6 +109,9 @@
>                      wsdlURL = uri.toURL();
>                  }
>                  wsdlURL = deploymentContext.getClassLoader 
> ().getResource(location);
> +                if(null == wsdlURL){
> +                    throw new LoaderException("WSDL location error  
> '" +location+"'");
> +                }
>
Hi Rick,

Just noticed a quick thing here: location should probably be set with  
LoaderException.setResourceURI() rather than concatenated on the  
message so the error can be internationalized easily.

Jim
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tuscany-commits-unsubscribe@ws.apache.org
> For additional commands, e-mail: tuscany-commits-help@ws.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org