Re: [PR] [SPARK-48742][SS] Virtual Column Family for RocksDB [spark]

["jingz-db (via GitHub)" <gi...@apache.org>]

jingz-db commented on code in PR #47107:
URL: https://github.com/apache/spark/pull/47107#discussion_r1659517463


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/HDFSBackedStateStoreProvider.scala:
##########
@@ -126,6 +126,7 @@ private[sql] class HDFSBackedStateStoreProvider extends StateStoreProvider with
         valueSchema: StructType,
         keyStateEncoderSpec: KeyStateEncoderSpec,
         useMultipleValuesPerKey: Boolean = false,

Review Comment:
   TODO: as discussed with Anish today, will made this a ENUM type and passed into RocksDB



##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -2168,6 +2168,15 @@ object SQLConf {
       .checkValue(v => Set(1, 2).contains(v), "Valid versions are 1 and 2")
       .createWithDefault(2)
 
+  val STREAMING_ROCKSDB_VIRTUAL_COL_FAMILY_ENABLED =

Review Comment:
   TODO: remove this config, and pass virtual col family as an argument similar as `useColumnFamilies` per operator based



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org