You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by kunal642 <gi...@git.apache.org> on 2017/06/14 09:16:12 UTC

[GitHub] carbondata pull request #1031: [CARBONDATA-1170] Added condition to skip sin...

GitHub user kunal642 opened a pull request:

    https://github.com/apache/carbondata/pull/1031

    [CARBONDATA-1170] Added condition to skip single_pass for first load

    The user should not be able to load using "single_pass"="true" for the first load instead the load would be restarted with "single_pass"="false"

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kunal642/carbondata single_pass_restrictions

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1031.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1031
    
----
commit 00d9d2db83cfb4b08d5f317cc6a051e658130a0e
Author: kunal642 <ku...@knoldus.in>
Date:   2017-06-14T07:51:47Z

    added condition to skip single_pass for first load

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] carbondata issue #1031: [CARBONDATA-1170] Added condition to skip single_pas...

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1031
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2478/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] carbondata issue #1031: [CARBONDATA-1170] Added condition to skip single_pas...

Posted by gvramana <gi...@git.apache.org>.

Github user gvramana commented on the issue:

    https://github.com/apache/carbondata/pull/1031
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] carbondata pull request #1031: [CARBONDATA-1170] Added condition to skip sin...

Posted by gvramana <gi...@git.apache.org>.

Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1031#discussion_r122143866
  
    --- Diff: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchema.scala ---
    @@ -496,6 +496,15 @@ case class LoadTable(
             val dictFolderPath = carbonTablePath.getMetadataDirectoryPath
             val dimensions = carbonTable.getDimensionByTableName(
               carbonTable.getFactTableName).asScala.toArray
    +        if (null == carbonLoadModel.getLoadMetadataDetails) {
    +          CommonUtil.readLoadMetadataDetails(carbonLoadModel, storePath)
    --- End diff --
    
    Can use single pass for first load, but it will automatically fallback to twopass, which should be logged and continue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---