You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/05/21 04:13:04 UTC
[GitHub] [incubator-nuttx-apps] yamt commented on a change in pull request #250: Update make dependency for elf/module/nxflat/posix_spawn/sotest/thttpd
yamt commented on a change in pull request #250:
URL: https://github.com/apache/incubator-nuttx-apps/pull/250#discussion_r428435215
##########
File path: Application.mk
##########
@@ -219,7 +219,7 @@ else
context::
endif
-.depend: Makefile $(SRCS)
+.depend: Makefile $(wildcard $(SRCS))
Review comment:
@liuguo09 @xiaoxiang781216
doesn't this break apps using VPATH/--dep-path?
my app's Make.dep is empty after this change. (as wildcard expands to empty as no source files in the current directory)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org