You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Regis Xu (JIRA)" <ji...@apache.org> on 2007/07/24 10:22:31 UTC

[jira] Created: (HARMONY-4522) [classlib][sql] javax.sql.rowset.serial.DefaultUDTMap is not in spec

[classlib][sql] javax.sql.rowset.serial.DefaultUDTMap is not in spec
--------------------------------------------------------------------

                 Key: HARMONY-4522
                 URL: https://issues.apache.org/jira/browse/HARMONY-4522
             Project: Harmony
          Issue Type: Improvement
          Components: Classlib
            Reporter: Regis Xu


javax.sql.rowset.serial.DefaultUDTMap is not in spec (both 5 and 6), and i look through the source code, found it just a help class for javax.sql.rowset.serial.SerialArray.
I think we should move it to harmony internal package.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-4522) [classlib][sql] javax.sql.rowset.serial.DefaultUDTMap is not in spec

Posted by "Regis Xu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-4522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Regis Xu updated HARMONY-4522:
------------------------------

    Attachment: Harmony-4522.diff

This patch just remove "public" modifier from class. May somebody try this? Thanks.

> [classlib][sql] javax.sql.rowset.serial.DefaultUDTMap is not in spec
> --------------------------------------------------------------------
>
>                 Key: HARMONY-4522
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4522
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Regis Xu
>            Assignee: Paulex Yang
>         Attachments: Harmony-4522.diff, Harmony-4522.zip
>
>
> javax.sql.rowset.serial.DefaultUDTMap is not in spec (both 5 and 6), and i look through the source code, found it just a help class for javax.sql.rowset.serial.SerialArray.
> I think we should move it to harmony internal package.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HARMONY-4522) [classlib][sql] javax.sql.rowset.serial.DefaultUDTMap is not in spec

Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-4522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paulex Yang reassigned HARMONY-4522:
------------------------------------

    Assignee: Paulex Yang

> [classlib][sql] javax.sql.rowset.serial.DefaultUDTMap is not in spec
> --------------------------------------------------------------------
>
>                 Key: HARMONY-4522
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4522
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Regis Xu
>            Assignee: Paulex Yang
>         Attachments: Harmony-4522.zip
>
>
> javax.sql.rowset.serial.DefaultUDTMap is not in spec (both 5 and 6), and i look through the source code, found it just a help class for javax.sql.rowset.serial.SerialArray.
> I think we should move it to harmony internal package.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-4522) [classlib][sql] javax.sql.rowset.serial.DefaultUDTMap is not in spec

Posted by "Regis Xu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-4522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Regis Xu updated HARMONY-4522:
------------------------------

    Attachment: Harmony-4522.zip

This path move javax.sql.rowset.serial.DefaultUDTMap to org.apache.harmony.sql.util.DefaultUDTMap
unzip Harmony-4522.zip
Harmony-4522-java5.diff and Harmony-4522-java6.diff are pathes for java 5 and java 6 respectively.

May somebody pls try this?

> [classlib][sql] javax.sql.rowset.serial.DefaultUDTMap is not in spec
> --------------------------------------------------------------------
>
>                 Key: HARMONY-4522
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4522
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Regis Xu
>         Attachments: Harmony-4522.zip
>
>
> javax.sql.rowset.serial.DefaultUDTMap is not in spec (both 5 and 6), and i look through the source code, found it just a help class for javax.sql.rowset.serial.SerialArray.
> I think we should move it to harmony internal package.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-4522) [classlib][sql] javax.sql.rowset.serial.DefaultUDTMap is not in spec

Posted by "Regis Xu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-4522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Regis Xu updated HARMONY-4522:
------------------------------

    Patch Info: [Patch Available]

> [classlib][sql] javax.sql.rowset.serial.DefaultUDTMap is not in spec
> --------------------------------------------------------------------
>
>                 Key: HARMONY-4522
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4522
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Regis Xu
>            Assignee: Paulex Yang
>         Attachments: Harmony-4522.diff, Harmony-4522.zip
>
>
> javax.sql.rowset.serial.DefaultUDTMap is not in spec (both 5 and 6), and i look through the source code, found it just a help class for javax.sql.rowset.serial.SerialArray.
> I think we should move it to harmony internal package.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-4522) [classlib][sql] javax.sql.rowset.serial.DefaultUDTMap is not in spec

Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-4522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12515152 ] 

Paulex Yang commented on HARMONY-4522:
--------------------------------------

Regis,

Instead of creating a separated package for this single class, I'd rather make it package private, especially it's only referred by only 1 class. How do you think about this? Thanks.

> [classlib][sql] javax.sql.rowset.serial.DefaultUDTMap is not in spec
> --------------------------------------------------------------------
>
>                 Key: HARMONY-4522
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4522
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Regis Xu
>            Assignee: Paulex Yang
>         Attachments: Harmony-4522.zip
>
>
> javax.sql.rowset.serial.DefaultUDTMap is not in spec (both 5 and 6), and i look through the source code, found it just a help class for javax.sql.rowset.serial.SerialArray.
> I think we should move it to harmony internal package.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HARMONY-4522) [classlib][sql] javax.sql.rowset.serial.DefaultUDTMap is not in spec

Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-4522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paulex Yang resolved HARMONY-4522.
----------------------------------

    Resolution: Fixed

Regis, seems I've fixed it in same way at r590574, please verify it. Badly sorry for the delay.

> [classlib][sql] javax.sql.rowset.serial.DefaultUDTMap is not in spec
> --------------------------------------------------------------------
>
>                 Key: HARMONY-4522
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4522
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Regis Xu
>            Assignee: Paulex Yang
>         Attachments: Harmony-4522.diff, Harmony-4522.zip
>
>
> javax.sql.rowset.serial.DefaultUDTMap is not in spec (both 5 and 6), and i look through the source code, found it just a help class for javax.sql.rowset.serial.SerialArray.
> I think we should move it to harmony internal package.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-4522) [classlib][sql] javax.sql.rowset.serial.DefaultUDTMap is not in spec

Posted by "Regis Xu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-4522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12515226 ] 

Regis Xu commented on HARMONY-4522:
-----------------------------------

Paulex,

Do you mean just remve "public" modifier before class javax.sql.rowset.serial.DefaultUDTMap? 
I think it's fine and more simple. I would like to create patch for this solution.

> [classlib][sql] javax.sql.rowset.serial.DefaultUDTMap is not in spec
> --------------------------------------------------------------------
>
>                 Key: HARMONY-4522
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4522
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Regis Xu
>            Assignee: Paulex Yang
>         Attachments: Harmony-4522.zip
>
>
> javax.sql.rowset.serial.DefaultUDTMap is not in spec (both 5 and 6), and i look through the source code, found it just a help class for javax.sql.rowset.serial.SerialArray.
> I think we should move it to harmony internal package.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (HARMONY-4522) [classlib][sql] javax.sql.rowset.serial.DefaultUDTMap is not in spec

Posted by "Regis Xu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-4522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Regis Xu closed HARMONY-4522.
-----------------------------


Verified. Thanks Paulex.

> [classlib][sql] javax.sql.rowset.serial.DefaultUDTMap is not in spec
> --------------------------------------------------------------------
>
>                 Key: HARMONY-4522
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4522
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Regis Xu
>            Assignee: Paulex Yang
>         Attachments: Harmony-4522.diff, Harmony-4522.zip
>
>
> javax.sql.rowset.serial.DefaultUDTMap is not in spec (both 5 and 6), and i look through the source code, found it just a help class for javax.sql.rowset.serial.SerialArray.
> I think we should move it to harmony internal package.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.