You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by "0xmkzt (via GitHub)" <gi...@apache.org> on 2023/11/07 03:47:38 UTC
[PR] [type:fix] fix bug when refresh config [shenyu]
0xmkzt opened a new pull request, #5280:
URL: https://github.com/apache/shenyu/pull/5280
<!-- Describe your PR here; e.g. Fixes #issueNo -->
<!--
Thank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request.
-->
Make sure that:
- [x] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor-guide).
- [ ] You submit test cases (unit or integration tests) that back your changes.
- [x] Your local test passed `./mvnw clean install -Dmaven.javadoc.skip=true`.
The config repeat refresh and the `logCollector` repeat start when logging config is not updated.
Call code in `AbstractLogPluginDataHandler`
<img width="1064" alt="image" src="https://github.com/apache/shenyu/assets/143072873/8e8d5a38-c9e0-4275-b713-c7ee802807c3">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [type:fix] fix bug when refresh config [shenyu]
Posted by "yunlongn (via GitHub)" <gi...@apache.org>.
yunlongn merged PR #5280:
URL: https://github.com/apache/shenyu/pull/5280
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [type:fix] fix bug when refresh config [shenyu]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5280:
URL: https://github.com/apache/shenyu/pull/5280#issuecomment-1797714154
## [Codecov](https://app.codecov.io/gh/apache/shenyu/pull/5280?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#5280](https://app.codecov.io/gh/apache/shenyu/pull/5280?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (e8b242f) into [master](https://app.codecov.io/gh/apache/shenyu/commit/b532d4612aca567a50188126944921ac9955803e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (b532d46) will **decrease** coverage by `0.13%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #5280 +/- ##
============================================
- Coverage 61.62% 61.49% -0.13%
+ Complexity 8733 8724 -9
============================================
Files 1252 1252
Lines 38585 38585
Branches 3687 3687
============================================
- Hits 23777 23727 -50
- Misses 12713 12761 +48
- Partials 2095 2097 +2
```
| [Files](https://app.codecov.io/gh/apache/shenyu/pull/5280?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...ugin/huawei/lts/config/HuaweiLogCollectConfig.java](https://app.codecov.io/gh/apache/shenyu/pull/5280?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWxvZ2dpbmcvc2hlbnl1LXBsdWdpbi1sb2dnaW5nLWh1YXdlaS1sdHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vaHVhd2VpL2x0cy9jb25maWcvSHVhd2VpTG9nQ29sbGVjdENvbmZpZy5qYXZh) | `73.62% <0.00%> (+1.09%)` | :arrow_up: |
| [...icsearch/config/ElasticSearchLogCollectConfig.java](https://app.codecov.io/gh/apache/shenyu/pull/5280?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWxvZ2dpbmcvc2hlbnl1LXBsdWdpbi1sb2dnaW5nLWVsYXN0aWNzZWFyY2gvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vbG9nZ2luZy9lbGFzdGljc2VhcmNoL2NvbmZpZy9FbGFzdGljU2VhcmNoTG9nQ29sbGVjdENvbmZpZy5qYXZh) | `52.08% <0.00%> (ø)` | |
| [...in/logging/kafka/config/KafkaLogCollectConfig.java](https://app.codecov.io/gh/apache/shenyu/pull/5280?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWxvZ2dpbmcvc2hlbnl1LXBsdWdpbi1sb2dnaW5nLWthZmthL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcGx1Z2luL2xvZ2dpbmcva2Fma2EvY29uZmlnL0thZmthTG9nQ29sbGVjdENvbmZpZy5qYXZh) | `44.44% <0.00%> (ø)` | |
| [.../logging/pulsar/config/PulsarLogCollectConfig.java](https://app.codecov.io/gh/apache/shenyu/pull/5280?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWxvZ2dpbmcvc2hlbnl1LXBsdWdpbi1sb2dnaW5nLXB1bHNhci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9sb2dnaW5nL3B1bHNhci9jb25maWcvUHVsc2FyTG9nQ29sbGVjdENvbmZpZy5qYXZh) | `65.71% <0.00%> (ø)` | |
| [...ging/rocketmq/config/RocketMQLogCollectConfig.java](https://app.codecov.io/gh/apache/shenyu/pull/5280?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWxvZ2dpbmcvc2hlbnl1LXBsdWdpbi1sb2dnaW5nLXJvY2tldG1xL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcGx1Z2luL2xvZ2dpbmcvcm9ja2V0bXEvY29uZmlnL1JvY2tldE1RTG9nQ29sbGVjdENvbmZpZy5qYXZh) | `53.65% <0.00%> (ø)` | |
... and [6 files with indirect coverage changes](https://app.codecov.io/gh/apache/shenyu/pull/5280/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in [Chrome](https://chrome.google.com/webstore/detail/codecov/gedikamndpbemklijjkncpnolildpbgo) or [Firefox](https://addons.mozilla.org/en-US/firefox/addon/codecov/) today!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org