You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by sl...@apache.org on 2013/11/14 18:49:19 UTC

[1/5] git commit: add deprecation warning to cli

Updated Branches:
  refs/heads/trunk b92c55e68 -> c41eedf22


add deprecation warning to cli


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/1d3a4dd4
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/1d3a4dd4
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/1d3a4dd4

Branch: refs/heads/trunk
Commit: 1d3a4dd44facefa68696ead7fb89077811676c85
Parents: e02341b
Author: Jonathan Ellis <jb...@apache.org>
Authored: Wed Nov 13 14:33:02 2013 -0600
Committer: Jonathan Ellis <jb...@apache.org>
Committed: Wed Nov 13 14:33:02 2013 -0600

----------------------------------------------------------------------
 src/java/org/apache/cassandra/cli/CliClient.java | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cassandra/blob/1d3a4dd4/src/java/org/apache/cassandra/cli/CliClient.java
----------------------------------------------------------------------
diff --git a/src/java/org/apache/cassandra/cli/CliClient.java b/src/java/org/apache/cassandra/cli/CliClient.java
index c3d2600..8e72065 100644
--- a/src/java/org/apache/cassandra/cli/CliClient.java
+++ b/src/java/org/apache/cassandra/cli/CliClient.java
@@ -195,8 +195,8 @@ public class CliClient
     {
         sessionState.out.println("Welcome to Cassandra CLI version " + FBUtilities.getReleaseVersionString() + "\n");
 
-        sessionState.out.println("Please consider using the more convenient cqlsh instead of CLI");
-        sessionState.out.println("CQL3 is fully backwards compatible with Thrift data; see http://www.datastax.com/dev/blog/thrift-to-cql3\n");
+        sessionState.out.println("The CLI is deprecated and will be removed in Cassandra 3.0.  Consider migrating to cqlsh.");
+        sessionState.out.println("CQL is fully backwards compatible with Thrift data; see http://www.datastax.com/dev/blog/thrift-to-cql3\n");
 
         sessionState.out.println(getHelp().banner);
     }


[3/5] git commit: Fix AssertionError when doing set element deletion

Posted by sl...@apache.org.
Fix AssertionError when doing set element deletion

patch by slebresne; reviewed by iamaleksey for CASSANDRA-6341


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/4c08800b
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/4c08800b
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/4c08800b

Branch: refs/heads/trunk
Commit: 4c08800b4ca3ded8653686fc2cc99e3056a8a606
Parents: 9a594c3
Author: Sylvain Lebresne <sy...@datastax.com>
Authored: Thu Nov 14 18:46:12 2013 +0100
Committer: Sylvain Lebresne <sy...@datastax.com>
Committed: Thu Nov 14 18:46:12 2013 +0100

----------------------------------------------------------------------
 CHANGES.txt                                       | 1 +
 src/java/org/apache/cassandra/cql3/Operation.java | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cassandra/blob/4c08800b/CHANGES.txt
----------------------------------------------------------------------
diff --git a/CHANGES.txt b/CHANGES.txt
index f186c37..39a88f8 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -17,6 +17,7 @@
  * Fix json2sstable handling of range tombstones (CASSANDRA-6316)
  * Fix missing one row in reverse query (CASSANDRA-6330)
  * Fix reading expired row value from row cache (CASSANDRA-6325)
+ * Fix AssertionError when doing set element deletion (CASSANDRA-6341)
 
 
 1.2.11

http://git-wip-us.apache.org/repos/asf/cassandra/blob/4c08800b/src/java/org/apache/cassandra/cql3/Operation.java
----------------------------------------------------------------------
diff --git a/src/java/org/apache/cassandra/cql3/Operation.java b/src/java/org/apache/cassandra/cql3/Operation.java
index 2e16cea..8a659df 100644
--- a/src/java/org/apache/cassandra/cql3/Operation.java
+++ b/src/java/org/apache/cassandra/cql3/Operation.java
@@ -400,7 +400,7 @@ public abstract class Operation
                     return new Lists.DiscarderByIndex(id, idx);
                 case SET:
                     Term elt = element.prepare(Sets.valueSpecOf(receiver));
-                    return new Lists.Discarder(id, elt);
+                    return new Sets.Discarder(id, elt);
                 case MAP:
                     Term key = element.prepare(Maps.keySpecOf(receiver));
                     return new Maps.DiscarderByKey(id, key);


[2/5] git commit: Follow-up for 6327

Posted by sl...@apache.org.
Follow-up for 6327

patch by krummas; reviewed by slebresne for CASSANDRA-6327


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/731f58fc
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/731f58fc
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/731f58fc

Branch: refs/heads/trunk
Commit: 731f58fcd9d7e9810069de2d3ba9516b784afd34
Parents: 1d3a4dd
Author: Sylvain Lebresne <sy...@datastax.com>
Authored: Thu Nov 14 09:26:43 2013 +0100
Committer: Sylvain Lebresne <sy...@datastax.com>
Committed: Thu Nov 14 09:28:44 2013 +0100

----------------------------------------------------------------------
 src/java/org/apache/cassandra/db/marshal/CompositeType.java | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cassandra/blob/731f58fc/src/java/org/apache/cassandra/db/marshal/CompositeType.java
----------------------------------------------------------------------
diff --git a/src/java/org/apache/cassandra/db/marshal/CompositeType.java b/src/java/org/apache/cassandra/db/marshal/CompositeType.java
index c9e2ab9..5c1b62a 100644
--- a/src/java/org/apache/cassandra/db/marshal/CompositeType.java
+++ b/src/java/org/apache/cassandra/db/marshal/CompositeType.java
@@ -220,8 +220,11 @@ public class CompositeType extends AbstractCompositeType
     public boolean intersects(List<ByteBuffer> minColumnNames, List<ByteBuffer> maxColumnNames, SliceQueryFilter filter)
     {
         assert minColumnNames.size() == maxColumnNames.size();
+        outer:
         for (ColumnSlice slice : filter.slices)
         {
+            // This slices intersects if all component intersect. And we don't intersect
+            // only if no slice intersects
             ByteBuffer[] start = split(filter.isReversed() ? slice.finish : slice.start);
             ByteBuffer[] finish = split(filter.isReversed() ? slice.start : slice.finish);
             for (int i = 0; i < minColumnNames.size(); i++)
@@ -229,9 +232,10 @@ public class CompositeType extends AbstractCompositeType
                 AbstractType<?> t = types.get(i);
                 ByteBuffer s = i < start.length ? start[i] : ByteBufferUtil.EMPTY_BYTE_BUFFER;
                 ByteBuffer f = i < finish.length ? finish[i] : ByteBufferUtil.EMPTY_BYTE_BUFFER;
-                if (t.intersects(minColumnNames.get(i), maxColumnNames.get(i), s, f))
-                    return true;
+                if (!t.intersects(minColumnNames.get(i), maxColumnNames.get(i), s, f))
+                    continue outer;
             }
+            return true;
         }
         return false;
     }


[4/5] git commit: Merge branch 'cassandra-1.2' into cassandra-2.0

Posted by sl...@apache.org.
Merge branch 'cassandra-1.2' into cassandra-2.0


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/6fe83cda
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/6fe83cda
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/6fe83cda

Branch: refs/heads/trunk
Commit: 6fe83cdacbd8bf8f0a24b1dffce9d15ac08ae0d0
Parents: 731f58f 4c08800
Author: Sylvain Lebresne <sy...@datastax.com>
Authored: Thu Nov 14 18:47:50 2013 +0100
Committer: Sylvain Lebresne <sy...@datastax.com>
Committed: Thu Nov 14 18:47:50 2013 +0100

----------------------------------------------------------------------
 CHANGES.txt                                       | 1 +
 src/java/org/apache/cassandra/cql3/Operation.java | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cassandra/blob/6fe83cda/CHANGES.txt
----------------------------------------------------------------------
diff --cc CHANGES.txt
index 6a07720,39a88f8..17e97d5
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@@ -41,42 -17,10 +41,43 @@@ Merged from 1.2
   * Fix json2sstable handling of range tombstones (CASSANDRA-6316)
   * Fix missing one row in reverse query (CASSANDRA-6330)
   * Fix reading expired row value from row cache (CASSANDRA-6325)
+  * Fix AssertionError when doing set element deletion (CASSANDRA-6341)
  
  
 -1.2.11
 +2.0.2
 + * Update FailureDetector to use nanontime (CASSANDRA-4925)
 + * Fix FileCacheService regressions (CASSANDRA-6149)
 + * Never return WriteTimeout for CL.ANY (CASSANDRA-6032)
 + * Fix race conditions in bulk loader (CASSANDRA-6129)
 + * Add configurable metrics reporting (CASSANDRA-4430)
 + * drop queries exceeding a configurable number of tombstones (CASSANDRA-6117)
 + * Track and persist sstable read activity (CASSANDRA-5515)
 + * Fixes for speculative retry (CASSANDRA-5932, CASSANDRA-6194)
 + * Improve memory usage of metadata min/max column names (CASSANDRA-6077)
 + * Fix thrift validation refusing row markers on CQL3 tables (CASSANDRA-6081)
 + * Fix insertion of collections with CAS (CASSANDRA-6069)
 + * Correctly send metadata on SELECT COUNT (CASSANDRA-6080)
 + * Track clients' remote addresses in ClientState (CASSANDRA-6070)
 + * Create snapshot dir if it does not exist when migrating
 +   leveled manifest (CASSANDRA-6093)
 + * make sequential nodetool repair the default (CASSANDRA-5950)
 + * Add more hooks for compaction strategy implementations (CASSANDRA-6111)
 + * Fix potential NPE on composite 2ndary indexes (CASSANDRA-6098)
 + * Delete can potentially be skipped in batch (CASSANDRA-6115)
 + * Allow alter keyspace on system_traces (CASSANDRA-6016)
 + * Disallow empty column names in cql (CASSANDRA-6136)
 + * Use Java7 file-handling APIs and fix file moving on Windows (CASSANDRA-5383)
 + * Save compaction history to system keyspace (CASSANDRA-5078)
 + * Fix NPE if StorageService.getOperationMode() is executed before full startup (CASSANDRA-6166)
 + * CQL3: support pre-epoch longs for TimestampType (CASSANDRA-6212)
 + * Add reloadtriggers command to nodetool (CASSANDRA-4949)
 + * cqlsh: ignore empty 'value alias' in DESCRIBE (CASSANDRA-6139)
 + * Fix sstable loader (CASSANDRA-6205)
 + * Reject bootstrapping if the node already exists in gossip (CASSANDRA-5571)
 + * Fix NPE while loading paxos state (CASSANDRA-6211)
 + * cqlsh: add SHOW SESSION <tracing-session> command (CASSANDRA-6228)
 +Merged from 1.2:
 + * (Hadoop) Require CFRR batchSize to be at least 2 (CASSANDRA-6114)
   * Add a warning for small LCS sstable size (CASSANDRA-6191)
   * Add ability to list specific KS/CF combinations in nodetool cfstats (CASSANDRA-4191)
   * Mark CF clean if a mutation raced the drop and got it marked dirty (CASSANDRA-5946)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/6fe83cda/src/java/org/apache/cassandra/cql3/Operation.java
----------------------------------------------------------------------


[5/5] git commit: Merge branch 'cassandra-2.0' into trunk

Posted by sl...@apache.org.
Merge branch 'cassandra-2.0' into trunk


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/c41eedf2
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/c41eedf2
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/c41eedf2

Branch: refs/heads/trunk
Commit: c41eedf22f594f30ad53abaa1dfc84908d4b0ad9
Parents: b92c55e 6fe83cd
Author: Sylvain Lebresne <sy...@datastax.com>
Authored: Thu Nov 14 18:49:09 2013 +0100
Committer: Sylvain Lebresne <sy...@datastax.com>
Committed: Thu Nov 14 18:49:09 2013 +0100

----------------------------------------------------------------------
 CHANGES.txt                                                 | 1 +
 src/java/org/apache/cassandra/cli/CliClient.java            | 4 ++--
 src/java/org/apache/cassandra/cql3/Operation.java           | 2 +-
 src/java/org/apache/cassandra/db/marshal/CompositeType.java | 8 ++++++--
 4 files changed, 10 insertions(+), 5 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cassandra/blob/c41eedf2/CHANGES.txt
----------------------------------------------------------------------

http://git-wip-us.apache.org/repos/asf/cassandra/blob/c41eedf2/src/java/org/apache/cassandra/cli/CliClient.java
----------------------------------------------------------------------

http://git-wip-us.apache.org/repos/asf/cassandra/blob/c41eedf2/src/java/org/apache/cassandra/cql3/Operation.java
----------------------------------------------------------------------

http://git-wip-us.apache.org/repos/asf/cassandra/blob/c41eedf2/src/java/org/apache/cassandra/db/marshal/CompositeType.java
----------------------------------------------------------------------