You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/12/15 07:48:29 UTC

[GitHub] [incubator-yunikorn-core] wilfred-s commented on pull request #219: [YUNIKORN-352] - fixed max resource check and behavioural change

wilfred-s commented on pull request #219:
URL: https://github.com/apache/incubator-yunikorn-core/pull/219#issuecomment-745116652


   The patch looks good beside the codecov remarks.
   I can see that the error or no input cases are not hit based on the remarks it puts in. Specially in the resources `ComponentWiseMinPermissive()` we can get a couple easily fixed by nil testing. However this is a central part of the code and we should really strive for a higher test coverage.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org