[GitHub] [iotdb] CRZbulabula commented on a change in pull request #5400: Align class definitions of common concepts and move them into node-commons package

[GitBox <gi...@apache.org>]

CRZbulabula commented on a change in pull request #5400:
URL: https://github.com/apache/iotdb/pull/5400#discussion_r840699654



##########
File path: node-commons/src/main/java/org/apache/iotdb/commons/partition/ConsensusGroupId.java
##########
@@ -17,17 +17,17 @@
  * under the License.
  */
 
-package org.apache.iotdb.consensus.common;
+package org.apache.iotdb.commons.partition;

Review comment:
       Place the ConsensusGroupId in org.apache.iotdb.commons.consensus might be better.

##########
File path: node-commons/src/main/java/org/apache/iotdb/commons/partition/Endpoint.java
##########
@@ -17,7 +17,7 @@
  * under the License.
  */
 
-package org.apache.iotdb.consensus.common;
+package org.apache.iotdb.commons.partition;

Review comment:
       The Endpoint is not only used in partition module. For instance, the consensus layer also needs to use the Endpoint. So place the Endpoint to another package might be better. Like org.apache.iotdb.commons.tools?

##########
File path: node-commons/src/main/java/org/apache/iotdb/commons/partition/GroupType.java
##########
@@ -17,7 +17,7 @@
  * under the License.
  */
 
-package org.apache.iotdb.consensus.common;
+package org.apache.iotdb.commons.partition;

Review comment:
       Place the GroupType in org.apache.iotdb.commons.consensus might be better.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org