[GitHub] [superset] sowo opened a new pull request #18167: Fix(DeckGL): Fix issue with Javascript handlers in DeckGL plugin

[GitBox <gi...@apache.org>]

sowo opened a new pull request #18167:
URL: https://github.com/apache/superset/pull/18167


   
   ### SUMMARY
   Javascript data interceptor, Javascript tooltip generator and Javascript onclick href handlers throw error (runInNewContext is not a function) in 1.4 due to missing vm dependency. This change resolves the issue.
   
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   N/A
   
   ### TESTING INSTRUCTIONS
   Create or open a DeckGL chart that has one of the JS handlers  (data interceptor, tooltip generator and/or onclick href) configured. Without this fix, the chart will show an error condition once one of the handlers run.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org