You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Yash Sharma <ya...@gmail.com> on 2015/07/22 20:52:53 UTC

Review Request 36699: LENS-689 : Add doc for code module structure

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36699/
-----------------------------------------------------------

Review request for lens.


Repository: lens


Description
-------

Add doc for code module structure

https://issues.apache.org/jira/browse/LENS-689


Diffs
-----

  src/site/apt/developer/codestructure.apt PRE-CREATION 
  src/site/site.xml f26551c 

Diff: https://reviews.apache.org/r/36699/diff/


Testing
-------


Thanks,

Yash Sharma

Re: Review Request 36699: LENS-689 : Add doc for code module structure

Posted by Yash Sharma <ya...@gmail.com>.

> On July 23, 2015, 4:51 a.m., Amareshwari Sriramadasu wrote:
> > src/site/apt/developer/codestructure.apt, line 28
> > <https://reviews.apache.org/r/36699/diff/1/?file=1018948#file1018948line28>
> >
> >     Can you modify saying "contains API for Service, Driver, LensEvent, QueryRewriter and etc", instead of place of writing ?

Done !!


- Yash


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36699/#review92719
-----------------------------------------------------------


On July 23, 2015, 3:55 p.m., Yash Sharma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36699/
> -----------------------------------------------------------
> 
> (Updated July 23, 2015, 3:55 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Add doc for code module structure
> 
> https://issues.apache.org/jira/browse/LENS-689
> 
> 
> Diffs
> -----
> 
>   src/site/apt/developer/codestructure.apt PRE-CREATION 
>   src/site/site.xml f26551c 
> 
> Diff: https://reviews.apache.org/r/36699/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Yash Sharma
> 
>

Re: Review Request 36699: LENS-689 : Add doc for code module structure

Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36699/#review92719
-----------------------------------------------------------



src/site/apt/developer/codestructure.apt (line 28)
<https://reviews.apache.org/r/36699/#comment146963>

    Can you modify saying "contains API for Service, Driver, LensEvent, QueryRewriter and etc", instead of place of writing ?


- Amareshwari Sriramadasu


On July 22, 2015, 6:52 p.m., Yash Sharma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36699/
> -----------------------------------------------------------
> 
> (Updated July 22, 2015, 6:52 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Add doc for code module structure
> 
> https://issues.apache.org/jira/browse/LENS-689
> 
> 
> Diffs
> -----
> 
>   src/site/apt/developer/codestructure.apt PRE-CREATION 
>   src/site/site.xml f26551c 
> 
> Diff: https://reviews.apache.org/r/36699/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Yash Sharma
> 
>

Re: Review Request 36699: LENS-689 : Add doc for code module structure

Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36699/#review92869
-----------------------------------------------------------

Ship it!


Ship It!

- Amareshwari Sriramadasu


On July 23, 2015, 3:55 p.m., Yash Sharma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36699/
> -----------------------------------------------------------
> 
> (Updated July 23, 2015, 3:55 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Add doc for code module structure
> 
> https://issues.apache.org/jira/browse/LENS-689
> 
> 
> Diffs
> -----
> 
>   src/site/apt/developer/codestructure.apt PRE-CREATION 
>   src/site/site.xml f26551c 
> 
> Diff: https://reviews.apache.org/r/36699/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Yash Sharma
> 
>

Re: Review Request 36699: LENS-689 : Add doc for code module structure

Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36699/
-----------------------------------------------------------

(Updated July 23, 2015, 3:55 p.m.)


Review request for lens.


Changes
-------

Review Comments Implemented.


Repository: lens


Description
-------

Add doc for code module structure

https://issues.apache.org/jira/browse/LENS-689


Diffs (updated)
-----

  src/site/apt/developer/codestructure.apt PRE-CREATION 
  src/site/site.xml f26551c 

Diff: https://reviews.apache.org/r/36699/diff/


Testing
-------


Thanks,

Yash Sharma