[GitHub] [druid] abhishekagarwal87 commented on a change in pull request #11636: Add test for IS NOT NULL filter on join column in left join

[GitBox <gi...@apache.org>]

abhishekagarwal87 commented on a change in pull request #11636:
URL: https://github.com/apache/druid/pull/11636#discussion_r698296652



##########
File path: sql/src/test/java/org/apache/druid/sql/calcite/CalciteQueryTest.java
##########
@@ -18252,6 +18252,50 @@ public void testLeftJoinSubqueryWithSelectorFilter(Map<String, Object> queryCont
     );
   }
 
+  @Test
+  @Parameters(source = QueryContextForJoinProvider.class)

Review comment:
       Please share some context either here or in the PR description about why you are adding this test. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org