[jira] Commented: (HTTPCLIENT-895) Log creation impairs performance

["Tony Poppleton (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12783964#action_12783964 ] 

Tony Poppleton commented on HTTPCLIENT-895:
-------------------------------------------

The patch is for DefaultRequestDirector.java (revision 885491) and fails to apply properly (needs manual fixing) as the revision I just got from SVN is 885603.  Please advise.

When I ran my manually patched version there was a performance improvement on a small number of benchmarks I ran (I am seeing upto 10% improvement in my threads dealing with responses).

> Log creation impairs performance
> --------------------------------
>
>                 Key: HTTPCLIENT-895
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-895
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>          Components: HttpClient
>    Affects Versions: 4.0 Final
>            Reporter: Tony Poppleton
>            Priority: Minor
>         Attachments: HTTPCLIENT-895.patch
>
>
> Running JProfiler on a program that uses HttpClient with a ThreadSafeClientConnManager, revealed that 5% of the time was spent constructing Log instances in class ClientParamsStack.
> Oleg did some further investigation and found that DefaultRequestDirector also has the same problem.
> A simple solution would be to make the Log a static member variable, and do this on all classes for consistency.  However this might not be the best solution for interoperating with some frameworks (see http://wiki.apache.org/jakarta-commons/Logging/StaticLog)
> Another solution would be to simply remove the Log from the affected classes, although they are presumably there for a reason...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org