You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by milamberspace <gi...@git.apache.org> on 2016/05/20 12:43:22 UTC
[GitHub] cloudstack pull request: Add Java Default Certificat Authorities i...
GitHub user milamberspace opened a pull request:
https://github.com/apache/cloudstack/pull/1555
Add Java Default Certificat Authorities into the keystore if using a custom cert SSL
Related to CLOUDSTACK-1475
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/milamberspace/cloudstack Improve-CS-1475
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1555.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1555
----
commit a543b4ac5b2a86828a0106bf3c0b734593b59d4d
Author: Milamber <mi...@apache.org>
Date: 2016-05-20T08:20:12Z
Add Java Default Certificat Authorities into the keystore if using a custom cert SSL
Related to CLOUDSTACK-1475
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Add Java Default Certificat Authorities i...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1555#issuecomment-220778455
It seems that even without a custom SSL cert, one needs this PR to be able to download from other https sites (as the realhostip one is always loaded).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Add Java Default Certificat Authorities i...
Posted by milamberspace <gi...@git.apache.org>.
Github user milamberspace commented on the pull request:
https://github.com/apache/cloudstack/pull/1555#issuecomment-220764639
Travis & Jenkins are green. Ready for 2 x LGTM (easy review)
cc @DaanHoogland @rhtyd
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Add Java Default Certificat Authorities i...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1555#issuecomment-221759081
### CI RESULTS
```
Tests Run: 82
Skipped: 0
Failed: 0
Errors: 3
Duration: 8h 37m 16s
```
**Summary of the problem(s):**
```
ERROR: test suite for <class 'integration.smoke.test_vpc_vpn.TestRVPCSite2SiteVpn'>
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 209, in run
self.setUp()
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 292, in setUp
self.setupContext(ancestor)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 315, in setupContext
try_run(context, names)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, in try_run
return func()
File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", line 835, in setUpClass
cls.template.download(cls.apiclient)
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1350, in download
elif 'Downloaded' in template.status:
TypeError: argument of type 'NoneType' is not iterable
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_PGNO2P/results.txt
```
```
ERROR: test suite for <class 'integration.smoke.test_vpc_vpn.TestVpcRemoteAccessVpn'>
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 209, in run
self.setUp()
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 292, in setUp
self.setupContext(ancestor)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 315, in setupContext
try_run(context, names)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, in try_run
return func()
File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", line 293, in setUpClass
cls.template.download(cls.apiclient)
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1350, in download
elif 'Downloaded' in template.status:
TypeError: argument of type 'NoneType' is not iterable
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_PGNO2P/results.txt
```
```
ERROR: test suite for <class 'integration.smoke.test_vpc_vpn.TestVpcSite2SiteVpn'>
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 209, in run
self.setUp()
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 292, in setUp
self.setupContext(ancestor)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 315, in setupContext
try_run(context, names)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, in try_run
return func()
File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", line 472, in setUpClass
cls.template.download(cls.apiclient)
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1350, in download
elif 'Downloaded' in template.status:
TypeError: argument of type 'NoneType' is not iterable
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_PGNO2P/results.txt
```
**Associated Uploads**
**`/tmp/MarvinLogs/DeployDataCenter__May_25_2016_19_16_44_SKVYEG:`**
* [dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1555/tmp/MarvinLogs/DeployDataCenter__May_25_2016_19_16_44_SKVYEG/dc_entries.obj)
* [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1555/tmp/MarvinLogs/DeployDataCenter__May_25_2016_19_16_44_SKVYEG/failed_plus_exceptions.txt)
* [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1555/tmp/MarvinLogs/DeployDataCenter__May_25_2016_19_16_44_SKVYEG/runinfo.txt)
**`/tmp/MarvinLogs/test_network_PGNO2P:`**
* [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1555/tmp/MarvinLogs/test_network_PGNO2P/failed_plus_exceptions.txt)
* [results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1555/tmp/MarvinLogs/test_network_PGNO2P/results.txt)
* [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1555/tmp/MarvinLogs/test_network_PGNO2P/runinfo.txt)
**`/tmp/MarvinLogs/test_vpc_routers_NUW5WZ:`**
* [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1555/tmp/MarvinLogs/test_vpc_routers_NUW5WZ/failed_plus_exceptions.txt)
* [results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1555/tmp/MarvinLogs/test_vpc_routers_NUW5WZ/results.txt)
* [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1555/tmp/MarvinLogs/test_vpc_routers_NUW5WZ/runinfo.txt)
Uploads will be available until `2016-07-26 02:00:00 +0200 CEST`
*Comment created by [`upr comment`](https://github.com/cloudops/upr).*
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Add Java Default Certificat Authorities i...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1555#issuecomment-220771292
ping @ustcweizhou , does this suit Leaseweb?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Add Java Default Certificat Authorities i...
Posted by milamberspace <gi...@git.apache.org>.
Github user milamberspace commented on the pull request:
https://github.com/apache/cloudstack/pull/1555#issuecomment-220784860
I've fixed the English messages.
All is green. LGTM level reached. Ready to merge.
cc @swill
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Add Java Default Certificat Authorities i...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1555#issuecomment-220767434
Thanks @milamberspace! I was also looking into this and hacked around a bit. Your solution is nice! Now when a custom cert is used, the other CAs are also available and we're able to verify certificates again. Tested it, works fine so LGTM.
The only remaining issue I see is that I cannot connect to servers that require TLSv1.2. Need to look into that further and see if it's something on the SSVM or something on the remote server. But let's merge this as with this PR the situation when using a custom cert and when not using a cert are the same.
By the way, for already running environments, you can do this to import the missing certs:
```
defaultJavaKeyStoreFile=/etc/ssl/certs/java/cacerts
defaultJavaKeyStorePass=changeit
keyStore=/usr/local/cloud/systemvm/certs/realhostip.keystore
storepass="vmops.com"
keytool -importkeystore -srckeystore $defaultJavaKeyStoreFile -destkeystore $keyStore -srcstorepass $defaultJavaKeyStorePass -deststorepass $storepass
```
Result:
```
root@s-2-VM:~# keytool -importkeystore -srckeystore $defaultJavaKeyStoreFile -destkeystore $keyStore -srcstorepass $defaultJavaKeyStorePass -deststorepass $storepass
<cut>
Import command completed: 172 entries successfully imported, 0 entries failed or cancelled
```
Ping @swill
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Add Java Default Certificat Authorities i...
Posted by footplus <gi...@git.apache.org>.
Github user footplus commented on the pull request:
https://github.com/apache/cloudstack/pull/1555#issuecomment-221324378
Hum, please wait a bit before merging, it seems that in certain cases, a problem occurs; I'm not sure yet, but there may be more to it.
I'll double check what exactly is occurring (got agent disconnections on SSVM, not sure why, maybe unrelated). Upon restarting the service, got the following:
``
2016-05-24 16:13:00,805 WARN [utils.script.Script] (agentRequest-Handler-4:null) Timed out: /usr/local/cloud/systemvm/config_ssl.sh -i 1.2.3.4 -h s-400-VM -k /tmp/prvkey8397704182155251777.tmp -p /tmp/pubcert3668437820792344314.tmp -t /tmp/certchain6337729082886052511.tmp -u /tmp/rootcert3605556222455908935.tmp . Output is: Certificate was added to keystoreExisting entry alias debian:pscprocert.pem exists, overwrite? [no]: adding rewrite rules to file: /etc/apache2/sites-available/default-ssl
``
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Add Java Default Certificat Authorities i...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1555#issuecomment-221324840
Thanks for the update. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Add Java Default Certificat Authorities i...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1555#issuecomment-220778699
the message is not in good English, other then that LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Add Java Default Certificat Authorities i...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1555#discussion_r64134745
--- Diff: systemvm/scripts/config_ssl.sh ---
@@ -123,6 +123,8 @@ customCACert=
publicIp=
hostName=
keyStore=$(dirname $0)/certs/realhostip.keystore
+defaultJavaKeyStoreFile=/etc/ssl/certs/java/cacerts
+defaultJavaKeyStorePass=changeit
--- End diff --
Those are the defaults of the OS, so Debian in this case. The passwd is the default one from Java itself. I see no reason now why you should want that to be configurable. It is possible with a global settings, then passing that via cmd_line to the vm and read it here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Add Java Default Certificat Authorities i...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1555#discussion_r64134782
--- Diff: systemvm/scripts/config_ssl.sh ---
@@ -123,6 +123,8 @@ customCACert=
publicIp=
hostName=
keyStore=$(dirname $0)/certs/realhostip.keystore
+defaultJavaKeyStoreFile=/etc/ssl/certs/java/cacerts
+defaultJavaKeyStorePass=changeit
--- End diff --
fair enough
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Add Java Default Certificat Authorities i...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1555#issuecomment-221759242
This is ready to merge now. The issue we are seeing is a known issue not related to this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Add Java Default Certificat Authorities i...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1555#discussion_r64132608
--- Diff: systemvm/scripts/config_ssl.sh ---
@@ -167,7 +169,7 @@ then
fi
if [ ! -f "$customPrivKey" ]
then
- printf "priviate key file is not exist\n"
+ printf "private key file is not exist\n"
--- End diff --
nitpicking: 'does not exist' or 'is not in existence'
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Add Java Default Certificat Authorities i...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1555#discussion_r64134773
--- Diff: systemvm/scripts/config_ssl.sh ---
@@ -167,7 +169,7 @@ then
fi
if [ ! -f "$customPrivKey" ]
then
- printf "priviate key file is not exist\n"
+ printf "private key file is not exist\n"
--- End diff --
English is hard hehe
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Add Java Default Certificat Authorities i...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1555#issuecomment-221159974
I think this one is ready...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Add Java Default Certificat Authorities i...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1555#discussion_r64132615
--- Diff: systemvm/scripts/config_ssl.sh ---
@@ -123,6 +123,8 @@ customCACert=
publicIp=
hostName=
keyStore=$(dirname $0)/certs/realhostip.keystore
+defaultJavaKeyStoreFile=/etc/ssl/certs/java/cacerts
+defaultJavaKeyStorePass=changeit
--- End diff --
is there any mechanism to pass this in at anytime (install or call time)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Add Java Default Certificat Authorities i...
Posted by footplus <gi...@git.apache.org>.
Github user footplus commented on the pull request:
https://github.com/apache/cloudstack/pull/1555#issuecomment-221572152
LGTM \U0001f44d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Add Java Default Certificat Authorities i...
Posted by footplus <gi...@git.apache.org>.
Github user footplus commented on the pull request:
https://github.com/apache/cloudstack/pull/1555#issuecomment-220615734
LGTM :) It seems to work correctly on my 4.8.0 setup.
Thanks.
Best regards,
Aur�lien
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Add Java Default Certificat Authorities i...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1555#issuecomment-220882622
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Add Java Default Certificat Authorities i...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1555
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Add Java Default Certificat Authorities i...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1555#issuecomment-221159912
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 0
Errors: 0
Duration: 8h 55m 13s
```
**Associated Uploads**
**`/tmp/MarvinLogs/DeployDataCenter__May_22_2016_05_42_37_FOSXDW:`**
* [dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1555/tmp/MarvinLogs/DeployDataCenter__May_22_2016_05_42_37_FOSXDW/dc_entries.obj)
* [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1555/tmp/MarvinLogs/DeployDataCenter__May_22_2016_05_42_37_FOSXDW/failed_plus_exceptions.txt)
* [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1555/tmp/MarvinLogs/DeployDataCenter__May_22_2016_05_42_37_FOSXDW/runinfo.txt)
**`/tmp/MarvinLogs/test_network_O2B7I9:`**
* [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1555/tmp/MarvinLogs/test_network_O2B7I9/failed_plus_exceptions.txt)
* [results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1555/tmp/MarvinLogs/test_network_O2B7I9/results.txt)
* [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1555/tmp/MarvinLogs/test_network_O2B7I9/runinfo.txt)
**`/tmp/MarvinLogs/test_vpc_routers_XMB5CT:`**
* [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1555/tmp/MarvinLogs/test_vpc_routers_XMB5CT/failed_plus_exceptions.txt)
* [results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1555/tmp/MarvinLogs/test_vpc_routers_XMB5CT/results.txt)
* [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1555/tmp/MarvinLogs/test_vpc_routers_XMB5CT/runinfo.txt)
Uploads will be available until `2016-07-24 02:00:00 +0200 CEST`
*Comment created by [`upr comment`](https://github.com/cloudops/upr).*
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Add Java Default Certificat Authorities i...
Posted by footplus <gi...@git.apache.org>.
Github user footplus commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1555#discussion_r64432411
--- Diff: systemvm/scripts/config_ssl.sh ---
@@ -204,6 +203,7 @@ if [ -f "$customCACert" ]
then
keytool -delete -alias $aliasName -keystore $keyStore -storepass $storepass -noprompt
keytool -import -alias $aliasName -keystore $keyStore -storepass $storepass -noprompt -file $customCACert
+ keytool -importkeystore -srckeystore $defaultJavaKeyStoreFile -destkeystore $keyStore -srcstorepass $defaultJavaKeyStorePass -deststorepass $storepass
--- End diff --
It seems that we absolutely need a -noprompt option here, since re-applying the configuration will lead to keytool prompting whether to overwrite or not, and freezing the Agent then.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Add Java Default Certificat Authorities i...
Posted by milamberspace <gi...@git.apache.org>.
Github user milamberspace commented on the pull request:
https://github.com/apache/cloudstack/pull/1555#issuecomment-221497756
I add the noprompt option. Travis&Jenkins are green. Ready to merge.
cc @swill @footplus
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---