You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@auron.apache.org by "Tartarus0zm (via GitHub)" <gi...@apache.org> on 2025/10/22 03:47:14 UTC

[PR] [AURON #1493] Remove getSparkEnvConfAsString method from JniBridge [auron]

Tartarus0zm opened a new pull request, #1494:
URL: https://github.com/apache/auron/pull/1494

   <!--
   Thanks for sending a pull request!  Please keep the following tips in mind:
     - Start the PR title with the related issue ID, e.g. '[AURON #XXXX] Short summary...'.
     - Make your PR title clear and descriptive, summarizing what this PR changes.
     - Provide a concise example to reproduce the issue, if possible.
     - Keep the PR description up to date with all changes.
   -->
   
   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes #1493.
   
    # Rationale for this change
   <!--
    Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.  
   -->
   
   The `getSparkEnvConfAsString` API is tightly coupled with Spark and unused, so we need remove it from JniBridge.
   
   # What changes are included in this PR?
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   # Are there any user-facing changes?
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please add the `api change` label.
   -->
   
   # How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@auron.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [AURON #1493] Remove unused getSparkEnvConfAsString method from JniBridge [auron]

Posted by "merrily01 (via GitHub)" <gi...@apache.org>.
merrily01 commented on PR #1494:
URL: https://github.com/apache/auron/pull/1494#issuecomment-3430697113

   Thanks @Tartarus0zm 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@auron.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [AURON #1493] Remove getSparkEnvConfAsString method from JniBridge [auron]

Posted by "Tartarus0zm (via GitHub)" <gi...@apache.org>.
Tartarus0zm commented on PR #1494:
URL: https://github.com/apache/auron/pull/1494#issuecomment-3430414743

   @richox @merrily01  please take a moment to look at it. thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@auron.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [AURON #1493] Remove unused getSparkEnvConfAsString method from JniBridge [auron]

Posted by "merrily01 (via GitHub)" <gi...@apache.org>.
merrily01 merged PR #1494:
URL: https://github.com/apache/auron/pull/1494


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@auron.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org