[GitHub] [incubator-eventmesh] JunjieChou edited a comment on pull request #502: [ISSUE #339] add design doc for integrating OpenSchema

[GitBox <gi...@apache.org>]

JunjieChou edited a comment on pull request #502:
URL: https://github.com/apache/incubator-eventmesh/pull/502#issuecomment-903273924


   > LGTM, but there might one thing need to confirmed.
   > 
   > In this plan, the schema id will be added in each message. Does this will modify the current protocol? Maybe we should add the schema id in header or props?
   > I think the schema can be the metadata of a topic, then the producer doesn't need to send the schema id, and it also doesn't need to be notified when the scheme added/deleted in topics, since the validation and serialize is managed in eventmesh-runtime.
   
   As for the schema id, sure it could be added in the header as long as an MQ supports user-defined headers. Anyway, It's only about how to organize schema id which doesn't affect the architecture or processes.
   
   As for where to generate schema id, It might work to put it on eventmesh-runtime, but I have one question:
   How to set the format of messages(JSON?/JDK?/Avro?/...) between client and runtime? Maybe set it to JSON? because the current format is JSON and other types of format will introduce more problems😂.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org