You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/08/04 21:18:29 UTC
[GitHub] [cloudstack] GabrielBrascher opened a new pull request #4243: Update debian 10 iso to 10.5.0
GabrielBrascher opened a new pull request #4243:
URL: https://github.com/apache/cloudstack/pull/4243
## Description
Debian 10.4.0 is not available, therefore SystemVM templates will fail to build with a missing iso.
Fixed updating with the Debian 10.5.0 iso located at https://cdimage.debian.org/debian-cd/current/amd64/iso-cd/
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## How Has This Been Tested?
Executed command to build the template:
```
$ sudo bash build.sh systemvmtemplate
```
Check that the template was successfully generated with script `tools/appliance/build.sh`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4243: Update SystemVM debian iso from 10.4.0 to 10.5.0
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4243:
URL: https://github.com/apache/cloudstack/pull/4243#issuecomment-668955903
Packaging result: ✔centos7 ✖debian. JID-1649
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #4243: Update SystemVM debian iso from 10.4.0 to 10.5.0
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #4243:
URL: https://github.com/apache/cloudstack/pull/4243#issuecomment-668941952
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4243: Update SystemVM debian iso from 10.4.0 to 10.5.0
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4243:
URL: https://github.com/apache/cloudstack/pull/4243#issuecomment-669124309
Checked this, just URL/checksum change. Full smoketests not necessary, @GabrielBrascher have you found any reason we should build a new systemvmtemplate towards 4.15 release? Or keep using the build from June: http://download.cloudstack.org/systemvm/4.15/ cc @wido @DaanHoogland
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4243: Update SystemVM debian iso from 10.4.0 to 10.5.0
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4243:
URL: https://github.com/apache/cloudstack/pull/4243#issuecomment-668942364
@GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4243: Update SystemVM debian iso from 10.4.0 to 10.5.0
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4243:
URL: https://github.com/apache/cloudstack/pull/4243#issuecomment-669760306
if you need it you need it and i am fine with it. lgtm in that respect. i do not like the flimsy procedure we use, but i can live with it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #4243: Update SystemVM debian iso from 10.4.0 to 10.5.0
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #4243:
URL: https://github.com/apache/cloudstack/pull/4243#issuecomment-669222237
@DaanHoogland that is a good question. What do you think @rhtyd?
I can close this PR if you guys think it should be addressed inside a PR when the respective requires a new system VM template.
The downside is that it could catch some developer that is not used with the building template process; but on the other hand, we don't need to keep an eye looking for changes on the Debian 10.X.Y.
Alternatives that I see:
1. Update iso just if a new template is necessary
2. Create some fancy way to automatically update
3. Update at any time if someone struggle with building and sees it (no automation checking from time to time the ISO)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher closed pull request #4243: Update SystemVM debian iso from 10.4.0 to 10.5.0
Posted by GitBox <gi...@apache.org>.
GabrielBrascher closed pull request #4243:
URL: https://github.com/apache/cloudstack/pull/4243
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4243: Update SystemVM debian iso from 10.4.0 to 10.5.0
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4243:
URL: https://github.com/apache/cloudstack/pull/4243#issuecomment-669133107
@GabrielBrascher change gtm.
Do we expect debian to just remove older 10 releases when they update? This may lead to failures after we release as well. At least for anybody building their own systemVMs. What if we release and the day after they upgrade to 10.6?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #4243: Update SystemVM debian iso from 10.4.0 to 10.5.0
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #4243:
URL: https://github.com/apache/cloudstack/pull/4243#issuecomment-669160156
@DaanHoogland I was thinking the same. Do we need to constantly update that any time that there is another Debian 10.X?
That might be interesting thinking about new developers playing around with the system VM template. However, it might require some manual effort to keep it up to date.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #4243: Update SystemVM debian iso from 10.4.0 to 10.5.0
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #4243:
URL: https://github.com/apache/cloudstack/pull/4243#issuecomment-669157656
@rhtyd this happened while I was building a System VM template for testing Python3 development at PR #3730.
Depending on how #3730 progress we might or might not need a new template.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4243: Update SystemVM debian iso from 10.4.0 to 10.5.0
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4243:
URL: https://github.com/apache/cloudstack/pull/4243#issuecomment-669847049
The systemvm py scripts are patched via systemvm.iso, so we don't need a new template unless there's something in the 10.5 update. I'll merge this as it breaks build and review/compare changes against the June build.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4243: Update SystemVM debian iso from 10.4.0 to 10.5.0
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4243:
URL: https://github.com/apache/cloudstack/pull/4243#issuecomment-669163355
I like the idea but it will require designing a solution and might not be worth the effort. my question is mainly do we need this update now or do we wait till we know we need it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4243: Update SystemVM debian iso from 10.4.0 to 10.5.0
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4243:
URL: https://github.com/apache/cloudstack/pull/4243
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4243: Update SystemVM debian iso from 10.4.0 to 10.5.0
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4243:
URL: https://github.com/apache/cloudstack/pull/4243#issuecomment-669052453
Needs separate systemvm build if necessary
cc @DaanHoogland
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org