[GitHub] [kafka-site] machi1990 commented on a diff in pull request #506: KAFKA-14925: Hosting JS files locally

["machi1990 (via GitHub)" <gi...@apache.org>]

machi1990 commented on code in PR #506:
URL: https://github.com/apache/kafka-site/pull/506#discussion_r1174403250


##########
includes/_header.htm:
##########
@@ -17,7 +17,7 @@
 		<meta property="og:type" content="website" />
 		<link href="/css/fonts.css" rel="stylesheet">
 		<script src="/js/jquery.min.js"></script>
-		<script defer src="https://use.fontawesome.com/releases/v5.0.8/js/all.js"></script>
+		<script defer src="/js/all.js"></script>

Review Comment:
   let's give this file a descriptive name e.g `fontawesome.js`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org