You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Patrick Hunt (JIRA)" <ji...@apache.org> on 2008/08/11 20:08:44 UTC
[jira] Created: (ZOOKEEPER-118) findbugs flagged switch statement
in followerrequestprocessor.run()
findbugs flagged switch statement in followerrequestprocessor.run()
-------------------------------------------------------------------
Key: ZOOKEEPER-118
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-118
Project: Zookeeper
Issue Type: Bug
Components: server
Reporter: Patrick Hunt
Assignee: Flavio Paiva Junqueira
followerrequestprocessor:
is the case statement for SYNC supposed to fall through?
switch (request.type) {
case OpCode.sync:
zks.pendingSyncs.add(request);
case OpCode.create:
Please update the docs/code appropriately (if correct note it with comment just after the sync case statement.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-118) findbugs flagged switch statement
in followerrequestprocessor.run()
Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629285#action_12629285 ]
Flavio Paiva Junqueira commented on ZOOKEEPER-118:
--------------------------------------------------
This piece of code seems correct. Sync should be processed along with other quorum operations such as create, but it does require some special code. In this case case, a follower saves the pending sync operations it has received from its clients before forwarding it to the leader.
> findbugs flagged switch statement in followerrequestprocessor.run()
> -------------------------------------------------------------------
>
> Key: ZOOKEEPER-118
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-118
> Project: Zookeeper
> Issue Type: Bug
> Components: server
> Reporter: Patrick Hunt
> Assignee: Flavio Paiva Junqueira
>
> followerrequestprocessor:
> is the case statement for SYNC supposed to fall through?
> switch (request.type) {
> case OpCode.sync:
> zks.pendingSyncs.add(request);
> case OpCode.create:
> Please update the docs/code appropriately (if correct note it with comment just after the sync case statement.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-118) findbugs flagged switch statement
in followerrequestprocessor.run()
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-118:
-----------------------------------
Resolution: Fixed
Fix Version/s: 3.0.0
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
Committed revision 693529.
> findbugs flagged switch statement in followerrequestprocessor.run()
> -------------------------------------------------------------------
>
> Key: ZOOKEEPER-118
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-118
> Project: Zookeeper
> Issue Type: Bug
> Components: server
> Reporter: Patrick Hunt
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.0.0
>
> Attachments: ZOOKEEPER-118.patch
>
>
> followerrequestprocessor:
> is the case statement for SYNC supposed to fall through?
> switch (request.type) {
> case OpCode.sync:
> zks.pendingSyncs.add(request);
> case OpCode.create:
> Please update the docs/code appropriately (if correct note it with comment just after the sync case statement.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-118) findbugs flagged switch statement
in followerrequestprocessor.run()
Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Paiva Junqueira updated ZOOKEEPER-118:
---------------------------------------------
Status: Patch Available (was: Open)
The attached patch simply adds a comment to clarify the behavior of sync().
> findbugs flagged switch statement in followerrequestprocessor.run()
> -------------------------------------------------------------------
>
> Key: ZOOKEEPER-118
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-118
> Project: Zookeeper
> Issue Type: Bug
> Components: server
> Reporter: Patrick Hunt
> Assignee: Flavio Paiva Junqueira
> Attachments: ZOOKEEPER-118.patch
>
>
> followerrequestprocessor:
> is the case statement for SYNC supposed to fall through?
> switch (request.type) {
> case OpCode.sync:
> zks.pendingSyncs.add(request);
> case OpCode.create:
> Please update the docs/code appropriately (if correct note it with comment just after the sync case statement.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-118) findbugs flagged switch statement
in followerrequestprocessor.run()
Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Paiva Junqueira updated ZOOKEEPER-118:
---------------------------------------------
Attachment: ZOOKEEPER-118.patch
> findbugs flagged switch statement in followerrequestprocessor.run()
> -------------------------------------------------------------------
>
> Key: ZOOKEEPER-118
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-118
> Project: Zookeeper
> Issue Type: Bug
> Components: server
> Reporter: Patrick Hunt
> Assignee: Flavio Paiva Junqueira
> Attachments: ZOOKEEPER-118.patch
>
>
> followerrequestprocessor:
> is the case statement for SYNC supposed to fall through?
> switch (request.type) {
> case OpCode.sync:
> zks.pendingSyncs.add(request);
> case OpCode.create:
> Please update the docs/code appropriately (if correct note it with comment just after the sync case statement.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-118) findbugs flagged switch statement
in followerrequestprocessor.run()
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629759#action_12629759 ]
Hudson commented on ZOOKEEPER-118:
----------------------------------
Integrated in ZooKeeper-trunk #79 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/79/])
> findbugs flagged switch statement in followerrequestprocessor.run()
> -------------------------------------------------------------------
>
> Key: ZOOKEEPER-118
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-118
> Project: Zookeeper
> Issue Type: Bug
> Components: server
> Reporter: Patrick Hunt
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.0.0
>
> Attachments: ZOOKEEPER-118.patch
>
>
> followerrequestprocessor:
> is the case statement for SYNC supposed to fall through?
> switch (request.type) {
> case OpCode.sync:
> zks.pendingSyncs.add(request);
> case OpCode.create:
> Please update the docs/code appropriately (if correct note it with comment just after the sync case statement.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.