You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by Sssan520 <gi...@git.apache.org> on 2018/07/13 09:34:27 UTC
[GitHub] carbondata pull request #2506: [CARBONDATA-2682][32K] fix create table with ...
GitHub user Sssan520 opened a pull request:
https://github.com/apache/carbondata/pull/2506
[CARBONDATA-2682][32K] fix create table with long_string_columns properties bugs
Changes
This PR fixes create table with long_string_columns bugs which are:
1.create table with columns both in long_string_columns and partition or no_inverted_index property should be blocked.
2.create table with duplicate columns in long_string_column property should be blocked.
And already add new test cases to take care of testing this.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Sssan520/carbondata dts_longstringcols
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2506.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2506
----
commit 8f5d6a0ded3080f6c6d7021bf6618e4f823d34cd
Author: Sssan520 <li...@...>
Date: 2018-07-12T11:58:23Z
fix create table with long_string_columns properties bugs
----
---
[GitHub] carbondata issue #2506: [CARBONDATA-2682][32K] fix create table with long_st...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2506
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5874/
---
[GitHub] carbondata pull request #2506: [CARBONDATA-2682][32K] fix create table with ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2506
---
[GitHub] carbondata issue #2506: [CARBONDATA-2682][32K] fix create table with long_st...
Posted by Sssan520 <gi...@git.apache.org>.
Github user Sssan520 commented on the issue:
https://github.com/apache/carbondata/pull/2506
retest this please
---
[GitHub] carbondata issue #2506: [CARBONDATA-2682][32K] fix create table with long_st...
Posted by Sssan520 <gi...@git.apache.org>.
Github user Sssan520 commented on the issue:
https://github.com/apache/carbondata/pull/2506
retest this please
---
[GitHub] carbondata issue #2506: [CARBONDATA-2682][32K] fix create table with long_st...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2506
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7207/
---
[GitHub] carbondata issue #2506: [CARBONDATA-2682][32K] fix create table with long_st...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2506
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5982/
---
[GitHub] carbondata issue #2506: [CARBONDATA-2682][32K] fix create table with long_st...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2506
Can one of the admins verify this patch?
---
[GitHub] carbondata issue #2506: [CARBONDATA-2682][32K] fix create table with long_st...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2506
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5989/
---
[GitHub] carbondata issue #2506: [CARBONDATA-2682][32K] fix create table with long_st...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2506
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7213/
---
[GitHub] carbondata issue #2506: [CARBONDATA-2682][32K] fix create table with long_st...
Posted by Sssan520 <gi...@git.apache.org>.
Github user Sssan520 commented on the issue:
https://github.com/apache/carbondata/pull/2506
retest this please.
---
[GitHub] carbondata issue #2506: [CARBONDATA-2682][32K] fix create table with long_st...
Posted by xuchuanyin <gi...@git.apache.org>.
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2506
LGTM
---
[GitHub] carbondata issue #2506: [CARBONDATA-2682][32K] fix create table with long_st...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2506
Can one of the admins verify this patch?
---
[GitHub] carbondata issue #2506: [CARBONDATA-2682][32K] fix create table with long_st...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2506
Can one of the admins verify this patch?
---
[GitHub] carbondata issue #2506: [CARBONDATA-2682][32K] fix create table with long_st...
Posted by Sssan520 <gi...@git.apache.org>.
Github user Sssan520 commented on the issue:
https://github.com/apache/carbondata/pull/2506
retest this please
---
[GitHub] carbondata issue #2506: [CARBONDATA-2682][32K] fix create table with long_st...
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/2506
add to whitelist
---
[GitHub] carbondata issue #2506: [CARBONDATA-2682][32K] fix create table with long_st...
Posted by Sssan520 <gi...@git.apache.org>.
Github user Sssan520 commented on the issue:
https://github.com/apache/carbondata/pull/2506
There are some problems in the CI env, so I closed #2436 and opened this PR.
---
[GitHub] carbondata issue #2506: [CARBONDATA-2682][32K] fix create table with long_st...
Posted by xuchuanyin <gi...@git.apache.org>.
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2506
retest this please
---