[jira] [Commented] (ATLAS-1478) REST API endpoint to support adding a tag to multiple entities

["Sarath Subramanian (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ATLAS-1478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15832452#comment-15832452 ] 

Sarath Subramanian commented on ATLAS-1478:
-------------------------------------------

review comments:

1. GraphBackedMetadataRepository.java: 262
private void addTraitImpl(String guid, ITypedStruct traitInstance) throws RepositoryException {
        Preconditions.checkNotNull(traitInstance, "Trait instance cannot be null"); ---> This throws null pointer exception, you can consider throwing AtlasException with valid error code when traitInstance is invalid

2. DefaultMetadataService.java:583
if (!typeSystem.isRegistered(traitName)) {
            String msg = String.format("trait=%s should be defined in type system before it can be added", traitName);
            LOG.error(msg);
            throw new TypeNotFoundException(msg); ---> you can throw TraitNotFoundException with error message
        }

> REST API endpoint to support adding a tag to multiple entities
> --------------------------------------------------------------
>
>                 Key: ATLAS-1478
>                 URL: https://issues.apache.org/jira/browse/ATLAS-1478
>             Project: Atlas
>          Issue Type: Bug
>            Reporter: Vimal Sharma
>            Assignee: Vimal Sharma
>             Fix For: 0.8-incubating
>
>         Attachments: ATLAS-1478.patch, ATLAS-1478-v2.patch, ATLAS-1478-v3.patch
>
>
> Currently, there is no REST endpoint to add a tag to multiple entities. Add a REST endpoint in V2 APIs to support adding a tag to multiple entities in a single call.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)