You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "HaoYang670 (via GitHub)" <gi...@apache.org> on 2023/03/20 05:42:12 UTC
[GitHub] [arrow-datafusion] HaoYang670 opened a new issue, #5645: Move the file `/expr/src/type_coercion.rs` to the directory `/expr/src/type_coercion/` and rename it `mod`.
HaoYang670 opened a new issue, #5645:
URL: https://github.com/apache/arrow-datafusion/issues/5645
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
There are both a file and a directory named `type_coercion` under the `/expr/src`. It is better to move the file under the same named directory and rename it `mod`.
**Describe the solution you'd like**
<!--
A clear and concise description of what you want to happen.
-->
**Describe alternatives you've considered**
We could not do this if there are some reasons for the current implementation.
**Additional context**
<!--
Add any other context or screenshots about the feature request here.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] HaoYang670 commented on issue #5645: Move the file `/expr/src/type_coercion.rs` to the directory `/expr/src/type_coercion/` and rename it `mod`.
Posted by "HaoYang670 (via GitHub)" <gi...@apache.org>.
HaoYang670 commented on issue #5645:
URL: https://github.com/apache/arrow-datafusion/issues/5645#issuecomment-1475656503
I will try to file a PR this week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] HaoYang670 commented on issue #5645: Move the file `/expr/src/type_coercion.rs` to the directory `/expr/src/type_coercion/` and rename it `mod`.
Posted by "HaoYang670 (via GitHub)" <gi...@apache.org>.
HaoYang670 commented on issue #5645:
URL: https://github.com/apache/arrow-datafusion/issues/5645#issuecomment-1475659251
Hi @alamb is there any background why we have same named directory and file under a path?
I find we have the same named things for both `type_coercion` and `expr_rewriter` .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on issue #5645: Move the file `/expr/src/type_coercion.rs` to the directory `/expr/src/type_coercion/` and rename it `mod`.
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #5645:
URL: https://github.com/apache/arrow-datafusion/issues/5645#issuecomment-1476037848
> Hi @alamb is there any background why we have same named directory and file under a path?
> I find we have the same named things for both type_coercion and expr_rewriter .
I don't think there is any reason other than Rust allows for either.
Typically I think the file exists first (`type_coercion.rs`) and then when submodules are made it isn't renamed to mod.rs
It would be great to get DataFusion consistent in this regard (use `mod.rs`) 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on issue #5645: Move the file `/expr/src/type_coercion.rs` to the directory `/expr/src/type_coercion/` and rename it `mod`.
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #5645:
URL: https://github.com/apache/arrow-datafusion/issues/5645#issuecomment-1476037961
Thank you @HaoYang670
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb closed issue #5645: Move the file `/expr/src/type_coercion.rs` to the directory `/expr/src/type_coercion/` and rename it `mod`.
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb closed issue #5645: Move the file `/expr/src/type_coercion.rs` to the directory `/expr/src/type_coercion/` and rename it `mod`.
URL: https://github.com/apache/arrow-datafusion/issues/5645
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org