You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/04/21 21:06:04 UTC
[jira] [Commented] (BEAM-2049) Remove KeyedCombineFn
[ https://issues.apache.org/jira/browse/BEAM-2049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15979367#comment-15979367 ]
ASF GitHub Bot commented on BEAM-2049:
--------------------------------------
GitHub user kennknowles opened a pull request:
https://github.com/apache/beam/pull/2636
[BEAM-2049] Remove KeyedCombineFn
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
I think it is probably best to leave tweaking `StateTag` and `StateSpec` until a later PR...
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kennknowles/beam delete-KeyedCombineFn
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2636.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2636
----
commit 6ccacf632dd712750a46ba992683bde676213819
Author: Kenneth Knowles <kl...@google.com>
Date: 2017-04-21T21:04:02Z
Remove KeyedCombineFn
----
> Remove KeyedCombineFn
> ---------------------
>
> Key: BEAM-2049
> URL: https://issues.apache.org/jira/browse/BEAM-2049
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Fix For: First stable release
>
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)