You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/12/02 15:54:22 UTC

[GitHub] [shardingsphere] RaigorJiang commented on a diff in pull request #22605: Change minus to underscore in yaml

RaigorJiang commented on code in PR #22605:
URL: https://github.com/apache/shardingsphere/pull/22605#discussion_r1038283573


##########
docs/document/content/user-manual/shardingsphere-jdbc/yaml-config/rules/shadow.cn.md:
##########
@@ -18,9 +18,9 @@ rules:
   tables:
     <table-name>:
       dataSourceNames: # 影子表关联影子数据源名称列表
-        - <shadow-data-source>
+        - <shadow_data_source>
       shadowAlgorithmNames: # 影子表关联影子算法名称列表
-        - <shadow-algorithm-name>
+        - <shadow_algorithm_name>

Review Comment:
   The name `shadow_algorithm_name` should match the on in `shadowAlgorithms`



##########
docs/document/content/user-manual/shardingsphere-jdbc/yaml-config/rules/shadow.cn.md:
##########
@@ -18,9 +18,9 @@ rules:
   tables:
     <table-name>:
       dataSourceNames: # 影子表关联影子数据源名称列表
-        - <shadow-data-source>
+        - <shadow_data_source>
       shadowAlgorithmNames: # 影子表关联影子算法名称列表
-        - <shadow-algorithm-name>
+        - <shadow_algorithm_name>

Review Comment:
   The name `shadow_algorithm_name` should match the one in `shadowAlgorithms`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org