You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2020/01/25 00:41:05 UTC
[GitHub] [phoenix] gjacoby126 commented on a change in pull request #691:
PHOENIX-5694 Add MR job counters for IndexTool inline verification
gjacoby126 commented on a change in pull request #691: PHOENIX-5694 Add MR job counters for IndexTool inline verification
URL: https://github.com/apache/phoenix/pull/691#discussion_r370894846
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/IndexRebuildRegionScanner.java
##########
@@ -298,69 +655,71 @@ private boolean checkIndexRow(final byte[] indexRowKey, final Put put) throws IO
}
private void logToIndexToolOutputTable(byte[] dataRowKey, byte[] indexRowKey, long dataRowTs, long indexRowTs,
- String errorMsg) {
+ String errorMsg) throws IOException {
logToIndexToolOutputTable(dataRowKey, indexRowKey, dataRowTs, indexRowTs,
errorMsg, null, null);
}
private void logToIndexToolOutputTable(byte[] dataRowKey, byte[] indexRowKey, long dataRowTs, long indexRowTs,
- String errorMsg, byte[] expectedValue, byte[] actualValue) {
+ String errorMsg, byte[] expectedValue, byte[] actualValue) throws IOException {
final byte[] E_VALUE_PREFIX_BYTES = Bytes.toBytes(" E:");
final byte[] A_VALUE_PREFIX_BYTES = Bytes.toBytes(" A:");
final int PREFIX_LENGTH = 3;
final int TOTAL_PREFIX_LENGTH = 6;
+ final byte[] PHASE_BEFORE_VALUE = Bytes.toBytes("BEFORE");
+ final byte[] PHASE_AFTER_VALUE = Bytes.toBytes("AFTER");
+ long scanMaxTs = scan.getTimeRange().getMax();
+ byte[] keyPrefix = Bytes.toBytes(Long.toString(scanMaxTs));
+ byte[] rowKey;
+ if (dataRowKey != null) {
Review comment:
Again, good to document what the PK schema is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services