You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/09/07 14:20:09 UTC

[GitHub] [kafka] ijuma commented on a change in pull request #11307: KAFKA-13262: Remove final from `MockConsumer.close()` and delegate implementation

ijuma commented on a change in pull request #11307:
URL: https://github.com/apache/kafka/pull/11307#discussion_r703555946



##########
File path: clients/src/main/java/org/apache/kafka/clients/consumer/MockConsumer.java
##########
@@ -446,8 +447,8 @@ public synchronized void resume(Collection<TopicPartition> partitions) {
     }
 
     @Override
-    public final synchronized void close() {
-        this.closed = true;
+    public synchronized void close() {

Review comment:
       Makes sense, done.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org