[GitHub] [skywalking] sonatype-lift[bot] commented on a change in pull request #7477: Add support for extClassLoader

[GitBox <gi...@apache.org>]

sonatype-lift[bot] commented on a change in pull request #7477:
URL: https://github.com/apache/skywalking/pull/7477#discussion_r691257693



##########
File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/plugin/PluginBootstrap.java
##########
@@ -63,9 +64,7 @@
         for (PluginDefine pluginDefine : pluginClassList) {
             try {
                 LOGGER.debug("loading plugin class {}.", pluginDefine.getDefineClass());
-                AbstractClassEnhancePluginDefine plugin = (AbstractClassEnhancePluginDefine) Class.forName(pluginDefine.getDefineClass(), true, AgentClassLoader
-                    .getDefault()).newInstance();
-                plugins.add(plugin);
+                plugins.add(PluginInitializer.initialize(pluginDefine));

Review comment:
       *SHELL_INJECTION:*  UserControlledString(BufferedReader.readLine()) in procedure PluginCfg.load(...) at line 44 ~> ClassLoading(Class.forName(...)) in procedure PluginInitializer.create(...) at line 45.
   (at-me [in a reply](https://help.sonatype.com/lift) with `help` or `ignore`)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org