You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "fangpeina (via GitHub)" <gi...@apache.org> on 2026/01/22 15:20:21 UTC

[PR] system/ymodem: fix send err when partial write [nuttx-apps]

fangpeina opened a new pull request, #3370:
URL: https://github.com/apache/nuttx-apps/pull/3370

   ## Summary
   
   Fix buffer offset calculation in ymodem_send_buffer() to correctly handle partial writes by advancing the buffer pointer and adjusting the remaining size on each retry.
   
   ### Changes:
   - Fix buffer offset in write retry logic: change `write(fd, buf, size)` to `write(fd, buf + i, size - i)`
   
   ## Impact
   
   - **Features**: Fixes YMODEM transfer corruption on partial writes
   - **API Changes**: None
   - **Build**: No changes
   - **Hardware**: Affects UART devices with buffer constraints
   - **Documentation**: No changes needed
   - **Security**: No security implications
   - **Compatibility**: Fully backward compatible
   
   ## Testing
   
   Tested on UART with small write buffers. YMODEM file transfers complete successfully without corruption.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] system/ymodem: fix send err when partial write [nuttx-apps]

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #3370:
URL: https://github.com/apache/nuttx-apps/pull/3370


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org