You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by HeartSaVioR <gi...@git.apache.org> on 2017/12/06 12:59:35 UTC
[GitHub] storm pull request #2447: STORM-2845 Drop standalone mode of Storm SQL
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/2447
STORM-2845 Drop standalone mode of Storm SQL
* remove all related interfaces/classes on standalone mode
* migrate tests to trident mode which are associated to standalone mode
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HeartSaVioR/storm STORM-2845
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2447.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2447
----
commit 28583380608c30276bec55efe5710ed715896b40
Author: Jungtaek Lim <ka...@gmail.com>
Date: 2017-12-06T10:52:40Z
STORM-2845 Drop standalone mode of Storm SQL
* remove all related interfaces/classes on standalone mode
* migrate tests to trident mode which are associated to standalone mode
----
---
[GitHub] storm issue #2447: STORM-2845 Drop standalone mode of Storm SQL
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2447
Now I found the way to reduce the test execution time: rely on Avatica for some expression tests, which Calcite is also using the approach for its tests.
Build result in my local:
```
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] storm-sql-runtime .................................. SUCCESS [ 11.822 s]
[INFO] storm-sql-core ..................................... SUCCESS [01:39 min]
[INFO] storm-sql-kafka .................................... SUCCESS [ 3.782 s]
[INFO] storm-sql-redis .................................... SUCCESS [ 5.142 s]
[INFO] storm-sql-mongodb .................................. SUCCESS [ 3.638 s]
[INFO] storm-sql-hdfs ..................................... SUCCESS [ 11.517 s]
[INFO] sql ................................................ SUCCESS [ 0.035 s]
[INFO] ------------------------------------------------------------------------
```
---
[GitHub] storm issue #2447: STORM-2845 Drop standalone mode of Storm SQL
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2447
I've also refactored some classes.
There's huge increase in build time (close to 10 mins addition) which is due to migrate each test method to submit topology in local cluster. It ends up taking around 10 secs or more for each test method.
I'll try to come up with simple execution engine which is likely similar to standalone mode, but much simpler.
---
[GitHub] storm pull request #2447: STORM-2845 Drop standalone mode of Storm SQL
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2447
---
[GitHub] storm issue #2447: STORM-2845 Drop standalone mode of Storm SQL
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/2447
+1
---