[GitHub] [tomcat] martin-g commented on a change in pull request #445: Improve Travis CI build Performance

[GitBox <gi...@apache.org>]

martin-g commented on a change in pull request #445:
URL: https://github.com/apache/tomcat/pull/445#discussion_r690160756



##########
File path: .travis.yml
##########
@@ -90,3 +90,6 @@ after_failure:
 notifications:
     email:
       - dev@tomcat.apache.org
+cache:
+  directories:
+  - $HOME/.m2

Review comment:
       Tomcat does not use Maven so I see no reason to cache this folder.

##########
File path: .travis.yml
##########
@@ -80,7 +80,7 @@ install:
 
 script:
     - ant -q clean
-    - travis_wait 120 "./.travis/antTest.sh"
+    - "./.travis/antTest.sh"

Review comment:
       https://app.travis-ci.com/github/apache/tomcat/jobs/531899762 (the build for this PR) fails with `No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.`. So yes, `travis_wait` is needed!
   Maybe the duration should be reduced though.
   AFAIK Travis jobs could run for at most 50 mins but I see some which succeeded even after that...




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org