You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/10/27 12:15:12 UTC
[GitHub] [activemq-artemis] MM53 opened a new pull request #3820: ARTEMIS-3542 Avoid requesting LDAP root attribute
MM53 opened a new pull request #3820:
URL: https://github.com/apache/activemq-artemis/pull/3820
Check getAttributes with dn of user entry to avoid missing permissions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] MM53 commented on pull request #3820: ARTEMIS-3542 Avoid requesting LDAP root attribute
Posted by GitBox <gi...@apache.org>.
MM53 commented on pull request #3820:
URL: https://github.com/apache/activemq-artemis/pull/3820#issuecomment-991056585
Is there anything I forgot to do before this PR will be merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] asfgit closed pull request #3820: ARTEMIS-3542 Avoid requesting LDAP root attribute
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3820:
URL: https://github.com/apache/activemq-artemis/pull/3820
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] jbertram commented on pull request #3820: ARTEMIS-3542 Avoid requesting LDAP root attribute
Posted by GitBox <gi...@apache.org>.
jbertram commented on pull request #3820:
URL: https://github.com/apache/activemq-artemis/pull/3820#issuecomment-991082565
Sorry, @MM53. You didn't forget anything. Once the PR checks pass (running now) I'll merge it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] jbertram commented on pull request #3820: ARTEMIS-3542 Avoid requesting LDAP root attribute
Posted by GitBox <gi...@apache.org>.
jbertram commented on pull request #3820:
URL: https://github.com/apache/activemq-artemis/pull/3820#issuecomment-953017819
@MM53, thanks for the PR!
I think the other `DEBUG` log messages in `bindUser` which reference `dn` should be changed to reference `userDn` instead since that's now the DN which is being authenticated. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] jbertram commented on pull request #3820: ARTEMIS-3542 Avoid requesting LDAP root attribute
Posted by GitBox <gi...@apache.org>.
jbertram commented on pull request #3820:
URL: https://github.com/apache/activemq-artemis/pull/3820#issuecomment-953090850
@MM53, sounds good. Thanks for clarifying.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] MM53 commented on pull request #3820: ARTEMIS-3542 Avoid requesting LDAP root attribute
Posted by GitBox <gi...@apache.org>.
MM53 commented on pull request #3820:
URL: https://github.com/apache/activemq-artemis/pull/3820#issuecomment-953059428
I didn't changed those references to `dn` because they refer to the full name of the user. The `userDn` only contains to the relative path because the `baseDn` defined in `CONNECTION_URL` is added automatically when calling `context.getAttributes`. Therefore I thought using the full name is more informative for debugging. I also could change it to always use `dn` or `userDn` if you wish.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org