You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/04/18 18:08:29 UTC

[GitHub] [flink] bowenli86 opened a new pull request #8214: [FLINK-11476] [SQL/TABLE] Create CatalogManager to manage multiple catalogs and encapsulate Calcite schema

bowenli86 opened a new pull request #8214: [FLINK-11476] [SQL/TABLE] Create CatalogManager to manage multiple catalogs and encapsulate Calcite schema
URL: https://github.com/apache/flink/pull/8214
 
 
   ## What is the purpose of the change
   
   This PR introduces CatalogManager API and implementation to manage all registered ReadableCatalog instances. It encapsulates catalogs and their interrelations with Calcite.
   
   It currently does not connect to planner yet, and has a couple followup TODOs:
   
   - [FLINK-12257] Convert CatalogBaseTable to org.apache.calcite.schema.Table so that planner can use unified catalog APIs
   - [FLINK-12258] Decouple CatalogManager with Calcite	
   
   ## Brief change log
   
   - Created CatalogManager to mange all catalogs
   - Created CatalogCalciteSchema and DatabaseCalciteSchema to model a strict two-level reference structure for Flink in Calcite, the full name of tables and views will be of format `<catalog_name>.<db_name>.<meta-object_name>`
   - Introduced a concept of "current catalog" and "current database" to CatalogManager to help resolve meta-objects paths in SQL. E.g. with this function, "select * from tbl" can be properly interpreted as "select * from <current_catalog>.<current_db>.tbl"
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   
   - Added FlinkCatalogManagerTest
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes)
     - If yes, how is the feature documented? (JavaDocs)
   
   Documentation will be added later on when the feature completes.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services