You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2026/06/14 04:41:53 UTC
[PR] [SPARK-57435][CORE][SQL][K8S] Avoid fully-qualified `o.a.s.internal.config` reference repetition [spark]
dongjoon-hyun opened a new pull request, #56495:
URL: https://github.com/apache/spark/pull/56495
### What changes were proposed in this pull request?
This PR replaces redundant fully-qualified `org.apache.spark.internal.config.*` references with the short names available through the package wildcard import.
- `KerberosConfDriverFeatureStep`, `RUtils`, and `SQLConf` already wildcard-import `org.apache.spark.internal.config._`, so the redundant prefix is simply dropped.
- `PythonUtils` adds the wildcard import and then drops the prefix in 5 references (including the `Python.*` members).
### Why are the changes needed?
The fully-qualified references are redundant and inconsistent with the surrounding code, which already uses the imported short names. This is a code cleanup with no functional change.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
No behavior change. Verified locally by compiling the affected modules and running scalastyle:
- `build/sbt core/compile catalyst/compile`
- `build/sbt -Pkubernetes kubernetes/compile`
- `build/sbt core/scalastyle`
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.8)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-57435][CORE][SQL][K8S] Avoid fully-qualified `o.a.s.internal.config` reference repetition [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #56495: [SPARK-57435][CORE][SQL][K8S] Avoid fully-qualified `o.a.s.internal.config` reference repetition
URL: https://github.com/apache/spark/pull/56495
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-57435][CORE][SQL][K8S] Avoid fully-qualified `o.a.s.internal.config` reference repetition [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #56495:
URL: https://github.com/apache/spark/pull/56495#issuecomment-4702258153
Thank you, @peter-toth .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org