[GitHub] conglei opened a new pull request #5631: [bug fix] Fixed forced percentage format on tooltips and bubble chart tooltips format.

[GitBox <gi...@apache.org>]

conglei opened a new pull request #5631: [bug fix] Fixed forced percentage format on tooltips and bubble chart tooltips format.
URL: https://github.com/apache/incubator-superset/pull/5631
 
 
   Bug 1: For line charts, when the y-axis is force to set as percentage (hen computing a "Percentage" or "Contribution" selected, we force a percentage format), the tooltip is not correctly reflected on this change. 
   
   Before:
   
   <img width="642" alt="screen shot 2018-08-14 at 1 32 03 pm" src="https://user-images.githubusercontent.com/2024960/44116864-866aa12c-9fc6-11e8-9b7e-649c39a29e4b.png">
   
   After:
   
   <img width="703" alt="screen shot 2018-08-14 at 1 29 32 pm" src="https://user-images.githubusercontent.com/2024960/44116873-8da8b7ee-9fc6-11e8-8afd-324de2b7da04.png">
   
   
   Bug 2: For bubble chart, the format of tooltip is not correct reflect on the x and y tick formats.
   
   Before:
   
   <img width="946" alt="screen shot 2018-08-14 at 1 31 44 pm" src="https://user-images.githubusercontent.com/2024960/44116921-acb5377a-9fc6-11e8-941e-95a1beebd02a.png">
   
   After:
   
   <img width="559" alt="screen shot 2018-08-14 at 1 30 56 pm" src="https://user-images.githubusercontent.com/2024960/44116947-bd5a6e2e-9fc6-11e8-8960-f866593545c4.png">
   
   cc: @john-bodley @michellethomas

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org