You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by "shahar1 (via GitHub)" <gi...@apache.org> on 2023/07/23 20:20:14 UTC

[GitHub] [airflow] shahar1 commented on pull request #32787: Add ExternalBranchPythonOperator (including unit tests)

shahar1 commented on PR #32787:
URL: https://github.com/apache/airflow/pull/32787#issuecomment-1646950752

   I inherited the unit tests for the new operator from test classes of `BaseTestPythonVirtualenvOperator` and `TestBranchOperator` - as it sort of mixes between them. 
   Probably not the software-wise best practice to do - but it was the fastest to implement.
   I didn't manage to adjust one of the inherited tests, so I overrode with a skipped test and left a TODO comment for anyone who wants to implement it in the future.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org