You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2020/01/03 09:52:32 UTC
[GitHub] [servicecomb-service-center] codecov-io edited a comment on issue
#615: Add comment for cache, add interface CacheReader,
to make it easy to understand
codecov-io edited a comment on issue #615: Add comment for cache, add interface CacheReader, to make it easy to understand
URL: https://github.com/apache/servicecomb-service-center/pull/615#issuecomment-570485210
# [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/615?src=pr&el=h1) Report
> Merging [#615](https://codecov.io/gh/apache/servicecomb-service-center/pull/615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/9fa82ac8c847ea6f62161865ad1fccf443d73b3f?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `80%`.
[](https://codecov.io/gh/apache/servicecomb-service-center/pull/615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #615 +/- ##
==========================================
+ Coverage 57.57% 57.58% +<.01%
==========================================
Files 205 205
Lines 15776 15776
==========================================
+ Hits 9083 9084 +1
Misses 6046 6046
+ Partials 647 646 -1
```
| [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/615?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [server/plugin/pkg/discovery/cache\_kv.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/615/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2NhY2hlX2t2Lmdv) | `95.78% <ø> (ø)` | :arrow_up: |
| [server/plugin/pkg/discovery/etcd/indexer\_etcd.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/615/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2V0Y2QvaW5kZXhlcl9ldGNkLmdv) | `100% <ø> (ø)` | :arrow_up: |
| [...rver/plugin/pkg/discovery/servicecenter/indexer.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/615/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvaW5kZXhlci5nbw==) | `0% <ø> (ø)` | :arrow_up: |
| [...rver/plugin/pkg/discovery/servicecenter/adaptor.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/615/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvYWRhcHRvci5nbw==) | `0% <ø> (ø)` | :arrow_up: |
| [server/plugin/pkg/discovery/etcd/indexer\_cache.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/615/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2V0Y2QvaW5kZXhlcl9jYWNoZS5nbw==) | `88.23% <ø> (ø)` | :arrow_up: |
| [server/plugin/pkg/discovery/etcd/adaptor.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/615/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2V0Y2QvYWRhcHRvci5nbw==) | `75% <ø> (ø)` | :arrow_up: |
| [server/plugin/pkg/discovery/etcd/cacher\_kv.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/615/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2V0Y2QvY2FjaGVyX2t2Lmdv) | `66.42% <0%> (ø)` | :arrow_up: |
| [server/plugin/pkg/discovery/cacher.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/615/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2NhY2hlci5nbw==) | `100% <100%> (ø)` | :arrow_up: |
| [server/core/backend/defer\_instance.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/615/diff?src=pr&el=tree#diff-c2VydmVyL2NvcmUvYmFja2VuZC9kZWZlcl9pbnN0YW5jZS5nbw==) | `86.02% <100%> (ø)` | :arrow_up: |
| [server/plugin/pkg/discovery/cache\_null.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/615/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2NhY2hlX251bGwuZ28=) | `100% <100%> (ø)` | :arrow_up: |
| ... and [8 more](https://codecov.io/gh/apache/servicecomb-service-center/pull/615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/615?src=pr&el=footer). Last update [9fa82ac...9a3c544](https://codecov.io/gh/apache/servicecomb-service-center/pull/615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services