[jira] [Commented] (HIVE-9711) ORC Vectorization DoubleColumnVector.isRepeating=false if all entries are NaN

["Hive QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-9711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14344995#comment-14344995 ] 

Hive QA commented on HIVE-9711:
-------------------------------



{color:red}Overall{color}: -1 at least one tests failed

Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12702109/HIVE-9711.1.patch

{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 7587 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_groupby3_map
{noformat}

Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/2929/testReport
Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/2929/console
Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-2929/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12702109 - PreCommit-HIVE-TRUNK-Build

> ORC Vectorization DoubleColumnVector.isRepeating=false if all entries are NaN
> -----------------------------------------------------------------------------
>
>                 Key: HIVE-9711
>                 URL: https://issues.apache.org/jira/browse/HIVE-9711
>             Project: Hive
>          Issue Type: Bug
>          Components: File Formats, Vectorization
>    Affects Versions: 1.2.0
>            Reporter: Gopal V
>            Assignee: Gopal V
>             Fix For: 1.2.0
>
>         Attachments: HIVE-9711.1.patch
>
>
> The isRepeating=true check uses Java equality, which results in NaN != NaN comparison operations.
> The noNulls case needs the current check folded into the previous loop, while the hasNulls case needs a logical AND of the isNull[] field instead of == comparisons.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)