Re: [PR] HIVE-30042: Fix LLAP encoded/vectorized read path for TIMESTAMP WITH LOCAL TIME ZONE on ORC tables [hive]

["vikramahuja1001 (via GitHub)" <gi...@apache.org>]

vikramahuja1001 commented on code in PR #6776:
URL: https://github.com/apache/hive/pull/6776#discussion_r4101095113


##########
ql/src/java/org/apache/hadoop/hive/ql/io/BatchToRowReader.java:
##########
@@ -526,6 +530,28 @@ public static TimestampWritableV2 nextTimestamp(ColumnVector vector,
     }
   }
 
+  public static TimestampLocalTZWritable nextTimestampLocalTZ(ColumnVector vector,
+                                                  int row,
+                                                  ZoneId timeZone,
+                                                  Object previous) {
+    if (vector.isRepeating) {
+      row = 0;
+    }
+    if (vector.noNulls || !vector.isNull[row]) {
+      TimestampLocalTZWritable result;
+      if (previous == null || previous.getClass() != TimestampLocalTZWritable.class) {
+        result = new TimestampLocalTZWritable();
+      } else {
+        result = (TimestampLocalTZWritable) previous;
+      }
+      TimestampColumnVector tcv = (TimestampColumnVector) vector;
+      result.set(new TimestampTZ(tcv.time[row] / 1000, tcv.nanos[row], timeZone));

Review Comment:
   Yes. Missed it. Have added it now. Thanks for pointing it out



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org