You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2015/05/12 18:59:10 UTC
Review Request 34115: RU: Should not complain about decommissioned
components
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34115/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez and Nate Cole.
Bugs: AMBARI-11073
https://issues.apache.org/jira/browse/AMBARI-11073
Repository: ambari
Description
-------
Rolling Upgrades currently complains about decommissioned datanodes and/or node managers during pre-requisites checks. We should be resilient to Decommision.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java 083d3f9
ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesDecommissionCheck.java 6ebfd1f
ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesDecommissionCheckTest.java 1c3056b
Diff: https://reviews.apache.org/r/34115/diff/
Testing
-------
Manual checks on live cluster.
Unit tests in progress
Thanks,
Dmitro Lisnichenko
Re: Review Request 34115: RU: Should not complain about decommissioned
components
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34115/
-----------------------------------------------------------
(Updated May 12, 2015, 5:59 p.m.)
Review request for Ambari, Alejandro Fernandez and Nate Cole.
Bugs: AMBARI-11073
https://issues.apache.org/jira/browse/AMBARI-11073
Repository: ambari
Description
-------
Rolling Upgrades currently complains about decommissioned datanodes and/or node managers during pre-requisites checks. We should be resilient to Decommision.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java 083d3f9
ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesDecommissionCheck.java 6ebfd1f
ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesDecommissionCheckTest.java 1c3056b
Diff: https://reviews.apache.org/r/34115/diff/
Testing (updated)
-------
Manual checks on live cluster.
Unit test results:
1 unrelated failure
Failed tests: testPopulateResourcesForRegexpMetrics(org.apache.ambari.server.controller.metrics.timeline.AMSPropertyProviderTest): expected:<...rics.%25.AvailableMB[]&appId=RESOURCEMANAG...> but was:<...rics.%25.AvailableMB[%2Cyarn.QueueMetrics.%25.AvailableMB._min%2Cyarn.QueueMetrics.%25.AvailableMB._max%2Cyarn.QueueMetrics.%25.AvailableMB._avg%2Cyarn.QueueMetrics.%25.AvailableMB._sum]&appId=RESOURCEMANAG...>
Tests run: 2963, Failures: 1, Errors: 0, Skipped: 20
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Views ...................................... SUCCESS [2.811s]
[INFO] Ambari Metrics Common ............................. SUCCESS [1.478s]
[INFO] Ambari Server ..................................... FAILURE [53:24.877s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 53:29.949s
[INFO] Finished at: Tue May 12 20:57:53 EEST 2015
[INFO] Final Memory: 33M/245M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.12:test (default-test) on project ambari-server: There are test failures.
[ERROR]
[ERROR] Please refer to /media/plextor/review_ambari/ambari-server/target/surefire-reports for the individual test results.
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn <goals> -rf :ambari-server
Thanks,
Dmitro Lisnichenko
Re: Review Request 34115: RU: Should not complain about decommissioned
components
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34115/#review83429
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On May 12, 2015, 4:59 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34115/
> -----------------------------------------------------------
>
> (Updated May 12, 2015, 4:59 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Nate Cole.
>
>
> Bugs: AMBARI-11073
> https://issues.apache.org/jira/browse/AMBARI-11073
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Rolling Upgrades currently complains about decommissioned datanodes and/or node managers during pre-requisites checks. We should be resilient to Decommision.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java 083d3f9
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesDecommissionCheck.java 6ebfd1f
> ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesDecommissionCheckTest.java 1c3056b
>
> Diff: https://reviews.apache.org/r/34115/diff/
>
>
> Testing
> -------
>
> Manual checks on live cluster.
> Unit tests in progress
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 34115: RU: Should not complain about decommissioned
components
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34115/#review83426
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On May 12, 2015, 12:59 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34115/
> -----------------------------------------------------------
>
> (Updated May 12, 2015, 12:59 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Nate Cole.
>
>
> Bugs: AMBARI-11073
> https://issues.apache.org/jira/browse/AMBARI-11073
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Rolling Upgrades currently complains about decommissioned datanodes and/or node managers during pre-requisites checks. We should be resilient to Decommision.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java 083d3f9
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesDecommissionCheck.java 6ebfd1f
> ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesDecommissionCheckTest.java 1c3056b
>
> Diff: https://reviews.apache.org/r/34115/diff/
>
>
> Testing
> -------
>
> Manual checks on live cluster.
> Unit tests in progress
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>