You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by jihoonson <gi...@git.apache.org> on 2015/10/08 10:17:09 UTC
[GitHub] tajo pull request: TAJO-1875: Resource leak after a query failure
GitHub user jihoonson opened a pull request:
https://github.com/apache/tajo/pull/815
TAJO-1875: Resource leak after a query failure
The main reason is that wrong resource release routine.
When TaskManager receives a task start event ```e```, it checks that ```e``` is the first task start event of the current eb. If so, it create a context for the current eb. Here, if an error occurs while creating a eb context, the resource assigned for ```e``` must be released.
However, in the current implementation, the resource release routine requires a task attempt id which will not exist with an eb start failure. As a result, resource manager loses the resource assigned for ```e```.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jihoonson/tajo-2 TAJO-1875
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/815.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #815
----
commit bdaa0c10866424bb300670cd1f47ad9a0776b101
Author: Jihoon Son <ji...@apache.org>
Date: 2015-10-08T08:07:46Z
TAJO-1875
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1875: Resource leak after a query failure
Posted by jinossy <gi...@git.apache.org>.
Github user jinossy commented on the pull request:
https://github.com/apache/tajo/pull/815#issuecomment-146471517
+1 Great!!
I verified 'mvn clean install’ and the test failure is not related to this patch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1875: Resource leak after a query failure
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tajo/pull/815
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---