You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/09/22 12:51:32 UTC

[GitHub] [airflow] MatthieuBlais opened a new pull request, #26593: SFTP Provider: Fix default folder permissions

MatthieuBlais opened a new pull request, #26593:
URL: https://github.com/apache/airflow/pull/26593

   Relates #26226 
   
   Fixing default mode when creating a directory with paramiko and convert decimal mode to octal mode ([paramiko documention](https://docs.paramiko.org/en/stable/api/sftp.html#paramiko.sftp_client.SFTPClient.mkdir))
   
   + Updating test cases to confirm permissions after masking out the default umask are as we expect whenever we create a new folder. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] uranusjr commented on pull request #26593: SFTP Provider: Fix default folder permissions

Posted by GitBox <gi...@apache.org>.

uranusjr commented on PR #26593:
URL: https://github.com/apache/airflow/pull/26593#issuecomment-1260369289

   Change them both to use octal. Using decimal is a bug in the first place.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #26593: SFTP Provider: Fix default folder permissions

Posted by GitBox <gi...@apache.org>.

potiuk commented on PR #26593:
URL: https://github.com/apache/airflow/pull/26593#issuecomment-1290755883

   cool !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk merged pull request #26593: SFTP Provider: Fix default folder permissions

Posted by GitBox <gi...@apache.org>.

potiuk merged PR #26593:
URL: https://github.com/apache/airflow/pull/26593


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] MatthieuBlais commented on pull request #26593: SFTP Provider: Fix default folder permissions

Posted by GitBox <gi...@apache.org>.

MatthieuBlais commented on PR #26593:
URL: https://github.com/apache/airflow/pull/26593#issuecomment-1255865323

   yep I can change the default value instead, like paramiko does. My only concern is that this other class function uses decimal default value instead of octal so wouldn't it be confusing?
   
   ```
   def mkdir(self, path: str, mode: int = 777) -> None:
           """
           Creates a directory on the remote system.
           :param path: full path to the remote directory to create
           :param mode: permissions to set the directory with
           """
           conn = self.get_conn()
           conn.mkdir(path, mode=int(str(mode), 8))
   ```       


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] uranusjr commented on pull request #26593: SFTP Provider: Fix default folder permissions

Posted by GitBox <gi...@apache.org>.

uranusjr commented on PR #26593:
URL: https://github.com/apache/airflow/pull/26593#issuecomment-1255006377

   I don’t think this is a good fix. Instead we should change the default to `0o777`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #26593: SFTP Provider: Fix default folder permissions

Posted by GitBox <gi...@apache.org>.

boring-cyborg[bot] commented on PR #26593:
URL: https://github.com/apache/airflow/pull/26593#issuecomment-1254979701

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org