You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/07/09 10:25:30 UTC
[GitHub] [flink] X-czh opened a new pull request, #20232: [FLINK-25371] Include data port as part of the host info for subtask detail panel on Web UI
X-czh opened a new pull request, #20232:
URL: https://github.com/apache/flink/pull/20232
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Help user locate the container where a task is running on from Web UI by including port in the host info on Web UI.
## Brief change log
Include port as part of the host info in `SubtaskExecutionAttemptDetailsInfo`.
## Verifying this change
This change is already covered by existing tests, such as `SubtaskCurrentAttemptDetailsHandlerTest.testHandleRequest()`.
Also manually verified the change by running a cluster.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / no) no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no) no
- The serializers: (yes / no / don't know) no
- The runtime per-record code paths (performance sensitive): (yes / no / don't know) no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know) no
- The S3 file system connector: (yes / no / don't know) no
## Documentation
- Does this pull request introduce a new feature? (yes / no) yes
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented) not documented
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-25371] Include data port as part of the host info for subtask detail panel on Web UI [flink]
Posted by "huwh (via GitHub)" <gi...@apache.org>.
huwh commented on PR #20232:
URL: https://github.com/apache/flink/pull/20232#issuecomment-1803645468
closed due to duplicating with "https://issues.apache.org/jira/browse/FLINK-33146".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] X-czh commented on a diff in pull request #20232: [FLINK-25371] Include data port as part of the host info for subtask detail panel on Web UI
Posted by "X-czh (via GitHub)" <gi...@apache.org>.
X-czh commented on code in PR #20232:
URL: https://github.com/apache/flink/pull/20232#discussion_r1289957395
##########
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/job/SubtaskExecutionAttemptDetailsInfo.java:
##########
@@ -203,7 +203,10 @@ public static SubtaskExecutionAttemptDetailsInfo create(
final long now = System.currentTimeMillis();
final TaskManagerLocation location = execution.getAssignedResourceLocation();
- final String locationString = location == null ? "(unassigned)" : location.getHostname();
+ final String locationString =
Review Comment:
Thanks for the comment, I'll align the location generation logic in different places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] X-czh commented on pull request #20232: [FLINK-25371] Include data port as part of the host info for subtask detail panel on Web UI
Posted by "X-czh (via GitHub)" <gi...@apache.org>.
X-czh commented on PR #20232:
URL: https://github.com/apache/flink/pull/20232#issuecomment-1671770972
@huwh Could you help review it again when you are free? Much appreciated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] huwh commented on a diff in pull request #20232: [FLINK-25371] Include data port as part of the host info for subtask detail panel on Web UI
Posted by "huwh (via GitHub)" <gi...@apache.org>.
huwh commented on code in PR #20232:
URL: https://github.com/apache/flink/pull/20232#discussion_r1315660721
##########
flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/job/SubtaskCurrentAttemptDetailsHandlerTest.java:
##########
@@ -186,7 +186,9 @@ public void testHandleRequest() throws Exception {
subtaskIndex,
expectedState,
attempt,
- assignedResourceLocation.getHostname(),
+ assignedResourceLocation.getHostname()
Review Comment:
assignedResourceLocation.getLocationString()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] huwh commented on a diff in pull request #20232: [FLINK-25371] Include data port as part of the host info for subtask detail panel on Web UI
Posted by "huwh (via GitHub)" <gi...@apache.org>.
huwh commented on code in PR #20232:
URL: https://github.com/apache/flink/pull/20232#discussion_r1315762231
##########
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/job/SubtaskExecutionAttemptDetailsInfo.java:
##########
@@ -203,7 +203,8 @@ public static SubtaskExecutionAttemptDetailsInfo create(
final long now = System.currentTimeMillis();
final TaskManagerLocation location = execution.getAssignedResourceLocation();
- final String locationString = location == null ? "(unassigned)" : location.getHostname();
+ final String locationString =
+ location == null ? "(unassigned)" : location.getLocationString();
Review Comment:
Good catch. It's better to align the name between the UI and the Rest API.
We need a FLIP and discussion in dev ML before this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] X-czh commented on a diff in pull request #20232: [FLINK-25371] Include data port as part of the host info for subtask detail panel on Web UI
Posted by "X-czh (via GitHub)" <gi...@apache.org>.
X-czh commented on code in PR #20232:
URL: https://github.com/apache/flink/pull/20232#discussion_r1315734864
##########
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/job/SubtaskExecutionAttemptDetailsInfo.java:
##########
@@ -203,7 +203,8 @@ public static SubtaskExecutionAttemptDetailsInfo create(
final long now = System.currentTimeMillis();
final TaskManagerLocation location = execution.getAssignedResourceLocation();
- final String locationString = location == null ? "(unassigned)" : location.getHostname();
+ final String locationString =
+ location == null ? "(unassigned)" : location.getLocationString();
Review Comment:
You made a good point. We should by no means rename the field directly as it breaks the backward-compatibility. I propose:
1. Add a new field called "location" (already used in `JobExceptionsInfoWithHistory`) for storing the host + port info.
2. Update the front-end to adopt the new location field.
3. Rename the column name from "Host" to "Location" on the Web UI (previously we reached consensus on using "Host:port", but after a second thought, I think "Location" is more concise)
4. Keep the old "host" field untouched. Notice that the info stored in the old "host" field is inconsistent, sometimes only host is stored, sometimes host + port is stored, I'll leave them as they were with a few comments to keep being compatible.
What do you think @1996fanrui @huwh ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] 1996fanrui commented on a diff in pull request #20232: [FLINK-25371] Include data port as part of the host info for subtask detail panel on Web UI
Posted by "1996fanrui (via GitHub)" <gi...@apache.org>.
1996fanrui commented on code in PR #20232:
URL: https://github.com/apache/flink/pull/20232#discussion_r1315731682
##########
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/job/SubtaskExecutionAttemptDetailsInfo.java:
##########
@@ -203,7 +203,8 @@ public static SubtaskExecutionAttemptDetailsInfo create(
final long now = System.currentTimeMillis();
final TaskManagerLocation location = execution.getAssignedResourceLocation();
- final String locationString = location == null ? "(unassigned)" : location.getHostname();
+ final String locationString =
+ location == null ? "(unassigned)" : location.getLocationString();
Review Comment:
Other rest api has this problem as well, such as:
- JobVertexTaskManagersInfo.TaskManagersInfo#host
- SubtasksTimesInfo.SubtaskTimeInfo#host
- SubtasksAllAccumulatorsInfo.SubtaskAccumulatorsInfo#host
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] 1996fanrui commented on pull request #20232: [FLINK-25371] Include data port as part of the host info for subtask detail panel on Web UI
Posted by "1996fanrui (via GitHub)" <gi...@apache.org>.
1996fanrui commented on PR #20232:
URL: https://github.com/apache/flink/pull/20232#issuecomment-1676337619
> How about using "Host:port" in the title in both the subtask details panel and tasks manager details panel?
Sounds make sense to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] X-czh commented on a diff in pull request #20232: [FLINK-25371] Include data port as part of the host info for subtask detail panel on Web UI
Posted by "X-czh (via GitHub)" <gi...@apache.org>.
X-czh commented on code in PR #20232:
URL: https://github.com/apache/flink/pull/20232#discussion_r1315725139
##########
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/TaskManagerLocation.java:
##########
@@ -275,6 +275,15 @@ public static String getHostName(InetAddress inetAddress) {
return hostName;
}
+ /**
+ * Gets the location string of the TaskManager in the format of "$HOST:$PORT".
+ *
+ * @return The location string of the TaskManager.
+ */
+ public String getLocationString() {
Review Comment:
Sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] X-czh commented on pull request #20232: [FLINK-25371] Include data port as part of the host info for subtask detail panel on Web UI
Posted by "X-czh (via GitHub)" <gi...@apache.org>.
X-czh commented on PR #20232:
URL: https://github.com/apache/flink/pull/20232#issuecomment-1705930989
@huwh @1996fanrui I've updated the PR with two new commits that aligns the behavior of pretty printing taskmanager locations and updates the Web UI accordingly. Please help review again when you are free, thanks~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] 1996fanrui commented on a diff in pull request #20232: [FLINK-25371] Include data port as part of the host info for subtask detail panel on Web UI
Posted by "1996fanrui (via GitHub)" <gi...@apache.org>.
1996fanrui commented on code in PR #20232:
URL: https://github.com/apache/flink/pull/20232#discussion_r1315713611
##########
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/job/SubtaskExecutionAttemptDetailsInfo.java:
##########
@@ -203,7 +203,8 @@ public static SubtaskExecutionAttemptDetailsInfo create(
final long now = System.currentTimeMillis();
final TaskManagerLocation location = execution.getAssignedResourceLocation();
- final String locationString = location == null ? "(unassigned)" : location.getHostname();
+ final String locationString =
+ location == null ? "(unassigned)" : location.getLocationString();
Review Comment:
The `SubtaskExecutionAttemptDetailsInfo#host` should rename, right?
Also, the `SubtaskExecutionAttemptDetailsInfo#FIELD_NAME_HOST` and the front-end should be renamed as well. However, I'm not sure whether the rest api is called by flink users. If yes, the change is incompatible. Should we adding an extra field to store the locationString?
Anyway, using the `host` to store `locationString` for rest api does't make sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] X-czh commented on pull request #20232: [FLINK-25371] Include data port as part of the host info for subtask detail panel on Web UI
Posted by "X-czh (via GitHub)" <gi...@apache.org>.
X-czh commented on PR #20232:
URL: https://github.com/apache/flink/pull/20232#issuecomment-1668863995
> The screenshot displays the task manager panel. You may need to upload the subtasks information.
Thanks for the comment. I've updated the MR description with the screenshot of the subtask info page.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] X-czh commented on pull request #20232: [FLINK-25371] Include data port as part of the host info for subtask detail panel on Web UI
Posted by "X-czh (via GitHub)" <gi...@apache.org>.
X-czh commented on PR #20232:
URL: https://github.com/apache/flink/pull/20232#issuecomment-1676282502
> location
Hi @1996fanrui, Thanks for the suggestion and I agree with that. How about using "Host:port" in the title in both the subtask details panel and tasks manager details panel?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-25371] Include data port as part of the host info for subtask detail panel on Web UI [flink]
Posted by "huwh (via GitHub)" <gi...@apache.org>.
huwh closed pull request #20232: [FLINK-25371] Include data port as part of the host info for subtask detail panel on Web UI
URL: https://github.com/apache/flink/pull/20232
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] 1996fanrui commented on a diff in pull request #20232: [FLINK-25371] Include data port as part of the host info for subtask detail panel on Web UI
Posted by "1996fanrui (via GitHub)" <gi...@apache.org>.
1996fanrui commented on code in PR #20232:
URL: https://github.com/apache/flink/pull/20232#discussion_r1315711282
##########
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/TaskManagerLocation.java:
##########
@@ -275,6 +275,15 @@ public static String getHostName(InetAddress inetAddress) {
return hostName;
}
+ /**
+ * Gets the location string of the TaskManager in the format of "$HOST:$PORT".
+ *
+ * @return The location string of the TaskManager.
+ */
+ public String getLocationString() {
Review Comment:
Could you help add some tests for this method?
##########
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/job/SubtaskExecutionAttemptDetailsInfo.java:
##########
@@ -203,7 +203,8 @@ public static SubtaskExecutionAttemptDetailsInfo create(
final long now = System.currentTimeMillis();
final TaskManagerLocation location = execution.getAssignedResourceLocation();
- final String locationString = location == null ? "(unassigned)" : location.getHostname();
+ final String locationString =
+ location == null ? "(unassigned)" : location.getLocationString();
Review Comment:
The `SubtaskExecutionAttemptDetailsInfo#host` should rename, right?
Also, the `SubtaskExecutionAttemptDetailsInfo#FIELD_NAME_HOST` and the front-end should be renamed as well. However, I'm not sure whether the interface is called by flink users. If yes, the change is incompatible.Should we adding an extra field to store the locationString?
Anyway, using the `host` to store `locationString` for rest api does't make sense.
##########
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/JobVertexTaskManagersHandler.java:
##########
@@ -142,9 +142,7 @@ private static JobVertexTaskManagersInfo createJobVertexTaskManagersInfo(
for (AccessExecution execution : vertex.getCurrentExecutions()) {
TaskManagerLocation location = execution.getAssignedResourceLocation();
String taskManagerHost =
Review Comment:
```suggestion
String locationString =
```
how about this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] X-czh commented on a diff in pull request #20232: [FLINK-25371] Include data port as part of the host info for subtask detail panel on Web UI
Posted by "X-czh (via GitHub)" <gi...@apache.org>.
X-czh commented on code in PR #20232:
URL: https://github.com/apache/flink/pull/20232#discussion_r1315777208
##########
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/job/SubtaskExecutionAttemptDetailsInfo.java:
##########
@@ -203,7 +203,8 @@ public static SubtaskExecutionAttemptDetailsInfo create(
final long now = System.currentTimeMillis();
final TaskManagerLocation location = execution.getAssignedResourceLocation();
- final String locationString = location == null ? "(unassigned)" : location.getHostname();
+ final String locationString =
+ location == null ? "(unassigned)" : location.getLocationString();
Review Comment:
As is reminded by others, changing REST API fields would normally require a FLIP. I'll send an email on the discuss thread first and prepare one if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] huwh commented on pull request #20232: [FLINK-25371] Include data port as part of the host info for subtask detail panel on Web UI
Posted by "huwh (via GitHub)" <gi...@apache.org>.
huwh commented on PR #20232:
URL: https://github.com/apache/flink/pull/20232#issuecomment-1668833443
The screenshot displays the task manager panel. You may need to upload the subtasks information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] X-czh commented on pull request #20232: [FLINK-25371] Include data port as part of the host info for subtask detail panel on Web UI
Posted by GitBox <gi...@apache.org>.
X-czh commented on PR #20232:
URL: https://github.com/apache/flink/pull/20232#issuecomment-1179928667
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #20232: [FLINK-25371] Include data port as part of the host info for subtask detail panel on Web UI
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #20232:
URL: https://github.com/apache/flink/pull/20232#issuecomment-1179520244
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "071904184f88310bc5a72a7dfda3581cbbd33faa",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "071904184f88310bc5a72a7dfda3581cbbd33faa",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 071904184f88310bc5a72a7dfda3581cbbd33faa UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] huwh commented on a diff in pull request #20232: [FLINK-25371] Include data port as part of the host info for subtask detail panel on Web UI
Posted by "huwh (via GitHub)" <gi...@apache.org>.
huwh commented on code in PR #20232:
URL: https://github.com/apache/flink/pull/20232#discussion_r1289638320
##########
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/job/SubtaskExecutionAttemptDetailsInfo.java:
##########
@@ -203,7 +203,10 @@ public static SubtaskExecutionAttemptDetailsInfo create(
final long now = System.currentTimeMillis();
final TaskManagerLocation location = execution.getAssignedResourceLocation();
- final String locationString = location == null ? "(unassigned)" : location.getHostname();
+ final String locationString =
Review Comment:
I've found that the API handles location in different ways, such as JobExceptionsHandler,JobVertexTaskManagersHandler, they connect the hostname and data port.
But for SubtasksAllAccumulatorsHandler,SubtasksTimesHandler,SubtaskExecutionAttemptDetailsInfo, they only use the hostname.
I think it's better to align these behaviors. We can extract the logic of the concat of hostname and port to a method of TaskManagerLocation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org