[GitHub] merlimat commented on a change in pull request #930: Issue #929: Perform async DNS resolution each time attempting connect?

[GitBox <gi...@apache.org>]

merlimat commented on a change in pull request #930: Issue #929: Perform async DNS resolution each time attempting connect?
URL: https://github.com/apache/incubator-pulsar/pull/930#discussion_r155130804
 
 

 ##########
 File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConnectionPool.java
 ##########
 @@ -195,14 +203,91 @@ public void initChannel(SocketChannel ch) throws Exception {
                 cnx.ctx().close();
                 return null;
             });
+        }).exceptionally(exception -> {
+            log.warn("Failed to open connection to {} : {}", physicalAddress, exception.getClass().getSimpleName());
 
 Review comment:
   We had that already in the existing code. It was to just use "ConnectionError" type names I think

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services