You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2018/07/11 16:30:19 UTC
[GitHub] iilyak opened a new pull request #1432: Support callback module
data provider
iilyak opened a new pull request #1432: Support callback module data provider
URL: https://github.com/apache/couchdb/pull/1432
## Overview
This fixes the use case when data provider module for `couch_epi` is not a pure functional.
To illustrate the issue let's look at the following code:
```
-export([data/0]).
data() ->
config:get("some_section").
```
We would want to regenerate dynamically compiled module when term returned from `data/0` is changed. However the previous implementation of `module` data provider was relying on `vsn` attribute of a module. Which is valid approach if the data term is hard coded in the module source.
This PR also renames `module` data provider into `static_module`.
## Testing recommendations
```
make eunit apps=couch_epi
```
## Checklist
- [x] Code is written and works correctly;
- [x] Changes are covered by tests;
- [x] Documentation reflects the changes;
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services