You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/06/09 02:49:06 UTC

[GitHub] [kafka] mjsax commented on pull request #10846: KAFKA-12914: StreamSourceNode should return `null` topic name for pattern subscription

mjsax commented on pull request #10846:
URL: https://github.com/apache/kafka/pull/10846#issuecomment-857329691


   > Just a thought that do you think it's better to return empty set when null?
   
   For `SourceGraphNode` we either set `topicName` or `pattern` `null`, and we also return `null` for the pattern case if `topicName` is used and `pattern is `null`. So I thought it might be better aligned to just return `null` if `topicName` is `null`, too. But I don't have a strong opinion.
   
   As an afterthought, it might even be better to change both return types to `Optional` ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org