You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@libcloud.apache.org by "Kami (via GitHub)" <gi...@apache.org> on 2024/04/18 16:16:07 UTC

Re: [PR] chore: Remove storage and volume interface implementation [libcloud]

Kami commented on PR #1972:
URL: https://github.com/apache/libcloud/pull/1972#issuecomment-2064411744

   @antoinebourayne I had a look and it looks like this comment is still relevant - https://github.com/apache/libcloud/pull/1972#issuecomment-1837447866
   
   I see `create_node()` method is still calling volume related methods which have been removed. `create_node()` should be updated to remove those calls and `disk` + `disk_size` argument should be removed as well (since it doesn't make sense / it's unused without corresponding volume management methods).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org