[GitHub] [activemq-artemis] jsmucr commented on a change in pull request #3172: ARTEMIS-2797 - Allow for removing current queue filter

[GitBox <gi...@apache.org>]

jsmucr commented on a change in pull request #3172:
URL: https://github.com/apache/activemq-artemis/pull/3172#discussion_r437892289



##########
File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java
##########
@@ -689,7 +689,10 @@ public QueueBinding updateQueue(QueueConfiguration queueConfiguration) throws Ex
                queue.setDelayBeforeDispatch(queueConfiguration.getDelayBeforeDispatch().longValue());
             }
             Filter filter = FilterImpl.createFilter(queueConfiguration.getFilterString());
-            if (filter != null && !filter.equals(queue.getFilter())) {
+            if ((filter == null) && (queue.getFilter() != null)) {

Review comment:
       I've added the config reload test.
   
   I'm not sure about what you mean by the default behavior. Shall I add some sort of constant (like `DEFAULT_FILTER`) or just document the fact that there's no filter by default and that setting it to `null` (by removing it from the configuration) or to `""` reverts it back to the default value?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org