You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mina.apache.org by ed...@apache.org on 2008/08/17 15:33:27 UTC
svn commit: r686611 -
/mina/trunk/core/src/test/java/org/apache/mina/transport/AbstractConnectorTest.java
Author: edeoliveira
Date: Sun Aug 17 06:33:27 2008
New Revision: 686611
URL: http://svn.apache.org/viewvc?rev=686611&view=rev
Log:
Reformatted and substituted StringBuffer by StringBuilder
Modified:
mina/trunk/core/src/test/java/org/apache/mina/transport/AbstractConnectorTest.java
Modified: mina/trunk/core/src/test/java/org/apache/mina/transport/AbstractConnectorTest.java
URL: http://svn.apache.org/viewvc/mina/trunk/core/src/test/java/org/apache/mina/transport/AbstractConnectorTest.java?rev=686611&r1=686610&r2=686611&view=diff
==============================================================================
--- mina/trunk/core/src/test/java/org/apache/mina/transport/AbstractConnectorTest.java (original)
+++ mina/trunk/core/src/test/java/org/apache/mina/transport/AbstractConnectorTest.java Sun Aug 17 06:33:27 2008
@@ -54,7 +54,7 @@
acceptor.bind(new InetSocketAddress(port));
try {
- final StringBuffer buf = new StringBuffer();
+ final StringBuilder buf = new StringBuilder();
IoConnector connector = createConnector();
connector.setHandler(new IoHandlerAdapter() {
@Override
@@ -87,7 +87,7 @@
public void testConnectFutureFailureTiming() throws Exception {
int port = AvailablePortFinder.getNextAvailable(3025);
- final StringBuffer buf = new StringBuffer();
+ final StringBuilder buf = new StringBuilder();
IoConnector connector = createConnector();
connector.setHandler(new IoHandlerAdapter() {
Re: svn commit: r686611 - /mina/trunk/core/src/test/java/org/apache/mina/transport/AbstractConnectorTest.java
Posted by Emmanuel Lecharny <el...@gmail.com>.
Hi,
are you sure this is thread safe ( StringBuilder is _not_ synchronized ) ?
(just checking :)
edeoliveira@apache.org wrote:
> Author: edeoliveira
> Date: Sun Aug 17 06:33:27 2008
> New Revision: 686611
>
> URL: http://svn.apache.org/viewvc?rev=686611&view=rev
> Log:
> Reformatted and substituted StringBuffer by StringBuilder
>
> Modified:
> mina/trunk/core/src/test/java/org/apache/mina/transport/AbstractConnectorTest.java
>
> Modified: mina/trunk/core/src/test/java/org/apache/mina/transport/AbstractConnectorTest.java
> URL: http://svn.apache.org/viewvc/mina/trunk/core/src/test/java/org/apache/mina/transport/AbstractConnectorTest.java?rev=686611&r1=686610&r2=686611&view=diff
> ==============================================================================
> --- mina/trunk/core/src/test/java/org/apache/mina/transport/AbstractConnectorTest.java (original)
> +++ mina/trunk/core/src/test/java/org/apache/mina/transport/AbstractConnectorTest.java Sun Aug 17 06:33:27 2008
> @@ -54,7 +54,7 @@
> acceptor.bind(new InetSocketAddress(port));
>
> try {
> - final StringBuffer buf = new StringBuffer();
> + final StringBuilder buf = new StringBuilder();
> IoConnector connector = createConnector();
> connector.setHandler(new IoHandlerAdapter() {
> @Override
> @@ -87,7 +87,7 @@
>
> public void testConnectFutureFailureTiming() throws Exception {
> int port = AvailablePortFinder.getNextAvailable(3025);
> - final StringBuffer buf = new StringBuffer();
> + final StringBuilder buf = new StringBuilder();
>
> IoConnector connector = createConnector();
> connector.setHandler(new IoHandlerAdapter() {
>
>
>
>
--
--
cordialement, regards,
Emmanuel Lécharny
www.iktek.com
directory.apache.org