You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/02/05 22:32:16 UTC
[GitHub] [netbeans] AlexFalappa opened a new pull request #1926:
[NETBEANS-3792] No more hardcoded colors in Remove Surrounding Code action
AlexFalappa opened a new pull request #1926: [NETBEANS-3792] No more hardcoded colors in Remove Surrounding Code action
URL: https://github.com/apache/netbeans/pull/1926
Exposed remove surrounding code color codes in editor color profile (Highlighting section):
Added color definitions to _NetBeans_, _Norway Today_, _CityLights_, _NetBeans55_, _NetBeans Earth_ and _FlatLaf Dark_ color profiles.
FlatLaf Dark before:
FlatLafDark after:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on issue #1926: [NETBEANS-3792] No
more hardcoded colors in Remove Surrounding Code action
Posted by GitBox <gi...@apache.org>.
eirikbakke commented on issue #1926: [NETBEANS-3792] No more hardcoded colors in Remove Surrounding Code action
URL: https://github.com/apache/netbeans/pull/1926#issuecomment-582911374
Myself, I'm not very familiar with the conventions of where to put which constants etc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] AlexFalappa commented on issue #1926: [NETBEANS-3792] No
more hardcoded colors in Remove Surrounding Code action
Posted by GitBox <gi...@apache.org>.
AlexFalappa commented on issue #1926: [NETBEANS-3792] No more hardcoded colors in Remove Surrounding Code action
URL: https://github.com/apache/netbeans/pull/1926#issuecomment-582843821
I have force pushed a new version where the bundle messages and fontcolors definitions are now in the `java/java.editor` module, closer to the _Remove Surrounding Code_ action.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] AlexFalappa commented on issue #1926: [NETBEANS-3792] No
more hardcoded colors in Remove Surrounding Code action
Posted by GitBox <gi...@apache.org>.
AlexFalappa commented on issue #1926: [NETBEANS-3792] No more hardcoded colors in Remove Surrounding Code action
URL: https://github.com/apache/netbeans/pull/1926#issuecomment-583014962
@lkishalmi some advanced functionalities are a bit hidden and hard to find, a _Tips and Tricks_ section in the wiki could be a good idea to raise user awareness.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] AlexFalappa commented on issue #1926: [NETBEANS-3792] No
more hardcoded colors in Remove Surrounding Code action
Posted by GitBox <gi...@apache.org>.
AlexFalappa commented on issue #1926: [NETBEANS-3792] No more hardcoded colors in Remove Surrounding Code action
URL: https://github.com/apache/netbeans/pull/1926#issuecomment-582847959
Colors in light color profiles (_NetBeans, NetBeans55, NetBeans Earth_) are those previously hardcoded in the action.
FlatLafLight (with NetBeans color profile) after:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi merged pull request #1926: [NETBEANS-3792] No
more hardcoded colors in Remove Surrounding Code action
Posted by GitBox <gi...@apache.org>.
lkishalmi merged pull request #1926: [NETBEANS-3792] No more hardcoded colors in Remove Surrounding Code action
URL: https://github.com/apache/netbeans/pull/1926
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on issue #1926: [NETBEANS-3792] No
more hardcoded colors in Remove Surrounding Code action
Posted by GitBox <gi...@apache.org>.
eirikbakke commented on issue #1926: [NETBEANS-3792] No more hardcoded colors in Remove Surrounding Code action
URL: https://github.com/apache/netbeans/pull/1926#issuecomment-583867775
Perhaps a Travis test for correct git user/email would be good. E.g. check it the git info against an "Authors.txt" file in the root directory of the repo, where new committers can add their names and email addresses.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni commented on issue #1926: [NETBEANS-3792] No
more hardcoded colors in Remove Surrounding Code action
Posted by GitBox <gi...@apache.org>.
ebarboni commented on issue #1926: [NETBEANS-3792] No more hardcoded colors in Remove Surrounding Code action
URL: https://github.com/apache/netbeans/pull/1926#issuecomment-584129262
@eirikbakke @matthiasblaesing is @eirikbakke proposition something we can do ? storing mail + name is something ok ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on issue #1926: [NETBEANS-3792]
No more hardcoded colors in Remove Surrounding Code action
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on issue #1926: [NETBEANS-3792] No more hardcoded colors in Remove Surrounding Code action
URL: https://github.com/apache/netbeans/pull/1926#issuecomment-583050046
@lkishalmi I didn't either - `ALT-BACKSPACE` or in Source menu - hmm, learn something new every day! :smile:
+1 fix looks like a good idea, and near to action makes sense - although begs the question why the action (if not the implementation) is Java specific.
Now, off to find out why `Insert Code` stopped working ... :confused:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] AlexFalappa commented on issue #1926: [NETBEANS-3792] No
more hardcoded colors in Remove Surrounding Code action
Posted by GitBox <gi...@apache.org>.
AlexFalappa commented on issue #1926: [NETBEANS-3792] No more hardcoded colors in Remove Surrounding Code action
URL: https://github.com/apache/netbeans/pull/1926#issuecomment-583848664
@matthiasblaesing just realised the initial commit has a wrong user. This may be due to the fact that the initial commit was performed at work and not at home where my git credentials are correct.
Apologise for the mess. Will be more careful in the future. My other PR should be correct in this regard.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on issue #1926:
[NETBEANS-3792] No more hardcoded colors in Remove Surrounding Code action
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on issue #1926: [NETBEANS-3792] No more hardcoded colors in Remove Surrounding Code action
URL: https://github.com/apache/netbeans/pull/1926#issuecomment-583844144
The author information for this commit is broken and should not have been merged. Neither the author name nor the email is valid. @AlexFalappa please fix your git settings to prevent this in the future. For all committers, please ensure, that commits like these are not merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] AlexFalappa commented on issue #1926: [NETBEANS-3792] No
more hardcoded colors in Remove Surrounding Code action
Posted by GitBox <gi...@apache.org>.
AlexFalappa commented on issue #1926: [NETBEANS-3792] No more hardcoded colors in Remove Surrounding Code action
URL: https://github.com/apache/netbeans/pull/1926#issuecomment-582844308
Dark Nimbus (with Norway Today color profile) after:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] AlexFalappa commented on issue #1926: [NETBEANS-3792] No
more hardcoded colors in Remove Surrounding Code action
Posted by GitBox <gi...@apache.org>.
AlexFalappa commented on issue #1926: [NETBEANS-3792] No more hardcoded colors in Remove Surrounding Code action
URL: https://github.com/apache/netbeans/pull/1926#issuecomment-582768117
I was wondering whether it would be more correct to move the bundle strings and default font color definitions from `ide/editor` module to `java/java.editor` module.
Something like PR #1875 by @lkishalmi .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke edited a comment on issue #1926:
[NETBEANS-3792] No more hardcoded colors in Remove Surrounding Code action
Posted by GitBox <gi...@apache.org>.
eirikbakke edited a comment on issue #1926: [NETBEANS-3792] No more hardcoded colors in Remove Surrounding Code action
URL: https://github.com/apache/netbeans/pull/1926#issuecomment-583867775
Perhaps a Travis test for correct git user/email would be good. E.g. it would check the git info against an "Authors.txt" file in the root directory of the repo, where new committers can add their well-formatted names and email addresses.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists